Skip to content

Commit afc7b59

Browse files
committed
wip
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent e07dded commit afc7b59

20 files changed

Lines changed: 425 additions & 96 deletions

File tree

encodings/alp/benches/alp_compress.rs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,14 @@ fn compress_alp<T: ALPFloat + NativePType>(bencher: Bencher, args: (usize, f64,
6666
let values = values.freeze();
6767
let array = PrimitiveArray::new(values, validity);
6868

69-
bencher
70-
.with_inputs(|| &array)
71-
.bench_values(|array| alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap())
69+
bencher.with_inputs(|| &array).bench_values(|array| {
70+
alp_encode(
71+
array.as_view(),
72+
None,
73+
&mut LEGACY_SESSION.create_execution_ctx(),
74+
)
75+
.unwrap()
76+
})
7277
}
7378

7479
#[divan::bench(types = [f32, f64], args = BENCH_ARGS)]

encodings/alp/src/alp/array.rs

Lines changed: 42 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,12 @@ mod tests {
582582
#[case(2049)]
583583
fn test_execute_f64(#[case] size: usize) {
584584
let values = PrimitiveArray::from_iter((0..size).map(|i| i as f64));
585-
let encoded = alp_encode(values.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
585+
let encoded = alp_encode(
586+
values.as_view(),
587+
None,
588+
&mut LEGACY_SESSION.create_execution_ctx(),
589+
)
590+
.unwrap();
586591

587592
let result_canonical = {
588593
let mut ctx = SESSION.create_execution_ctx();
@@ -616,7 +621,12 @@ mod tests {
616621
.collect();
617622

618623
let array = PrimitiveArray::from_iter(values);
619-
let encoded = alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
624+
let encoded = alp_encode(
625+
array.as_view(),
626+
None,
627+
&mut LEGACY_SESSION.create_execution_ctx(),
628+
)
629+
.unwrap();
620630
assert!(encoded.patches().unwrap().array_len() > 0);
621631

622632
let result_canonical = {
@@ -650,7 +660,12 @@ mod tests {
650660
.collect();
651661

652662
let array = PrimitiveArray::from_option_iter(values);
653-
let encoded = alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
663+
let encoded = alp_encode(
664+
array.as_view(),
665+
None,
666+
&mut LEGACY_SESSION.create_execution_ctx(),
667+
)
668+
.unwrap();
654669

655670
let result_canonical = {
656671
let mut ctx = SESSION.create_execution_ctx();
@@ -685,7 +700,12 @@ mod tests {
685700
.collect();
686701

687702
let array = PrimitiveArray::from_option_iter(values);
688-
let encoded = alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
703+
let encoded = alp_encode(
704+
array.as_view(),
705+
None,
706+
&mut LEGACY_SESSION.create_execution_ctx(),
707+
)
708+
.unwrap();
689709
assert!(encoded.patches().unwrap().array_len() > 0);
690710

691711
let result_canonical = {
@@ -721,7 +741,12 @@ mod tests {
721741
.collect();
722742

723743
let array = PrimitiveArray::from_option_iter(values.clone());
724-
let encoded = alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
744+
let encoded = alp_encode(
745+
array.as_view(),
746+
None,
747+
&mut LEGACY_SESSION.create_execution_ctx(),
748+
)
749+
.unwrap();
725750

726751
let slice_end = size - slice_start;
727752
let slice_len = slice_end - slice_start;
@@ -772,7 +797,12 @@ mod tests {
772797
.collect();
773798

774799
let array = PrimitiveArray::from_option_iter(values.clone());
775-
let encoded = alp_encode(array.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
800+
let encoded = alp_encode(
801+
array.as_view(),
802+
None,
803+
&mut LEGACY_SESSION.create_execution_ctx(),
804+
)
805+
.unwrap();
776806

777807
let slice_end = size - slice_start;
778808
let slice_len = slice_end - slice_start;
@@ -822,7 +852,12 @@ mod tests {
822852
let original = PrimitiveArray::from_iter(values);
823853

824854
// First encode normally to get a properly formed ALPArray with patches.
825-
let normally_encoded = alp_encode(original.as_view(), None, &mut LEGACY_SESSION.create_execution_ctx()).unwrap();
855+
let normally_encoded = alp_encode(
856+
original.as_view(),
857+
None,
858+
&mut LEGACY_SESSION.create_execution_ctx(),
859+
)
860+
.unwrap();
826861
assert!(
827862
normally_encoded.patches().is_some(),
828863
"Test requires patches to be present"

0 commit comments

Comments
 (0)