deprecate: execute_mask over to_mask (#7574)

deprecate to mask to allow execute_mask to take a context

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

encodings/alp/src/alp/array.rs

@@ -812,7 +812,7 @@ mod tests {
                 .as_ref()
                 .validity()
                 .unwrap()
-                .to_mask(result_primitive.as_ref().len(), &mut ctx)
+                .execute_mask(result_primitive.as_ref().len(), &mut ctx)
                 .unwrap()
                 .value(idx);
             assert_eq!(

encodings/alp/src/alp/compress.rs

@@ -79,7 +79,7 @@ where
     let validity = values
         .array()
         .validity()?
-        .to_mask(values.array().len(), ctx)?;
+        .execute_mask(values.array().len(), ctx)?;
     // exceptional_positions may contain exceptions at invalid positions (which contain garbage
     // data). We remove null exceptions in order to keep the Patches small.
     let (valid_exceptional_positions, valid_exceptional_values): (Buffer<u64>, Buffer<T>) =

encodings/alp/src/alp_rd/array.rs

@@ -273,7 +273,7 @@ impl VTable for ALPRD {
         let validity = left_parts
             .as_ref()
             .validity()?
-            .to_mask(left_parts.as_ref().len(), ctx)?;
+            .execute_mask(left_parts.as_ref().len(), ctx)?;
 
         let decoded_array = if ptype == PType::F32 {
             PrimitiveArray::new(

encodings/datetime-parts/src/canonical.rs

@@ -12,7 +12,6 @@ use vortex_array::dtype::PType;
 use vortex_array::extension::datetime::TimeUnit;
 use vortex_array::extension::datetime::Timestamp;
 use vortex_array::match_each_integer_ptype;
-use vortex_array::validity::Validity;
 use vortex_buffer::BufferMut;
 use vortex_error::VortexExpect as _;
 use vortex_error::VortexResult;
@@ -96,11 +95,7 @@ pub fn decode_to_temporal(
     }
 
     Ok(TemporalArray::new_timestamp(
-        PrimitiveArray::new(
-            values.freeze(),
-            Validity::copy_from_array(&array.clone().into_array())?,
-        )
-        .into_array(),
+        PrimitiveArray::new(values.freeze(), array.validity()?).into_array(),
         options.unit,
         options.tz.clone(),
     ))

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

@@ -206,7 +206,10 @@ pub fn gather_patches(
     };
 
     let array_len = parray.len();
-    let validity_mask = parray.as_ref().validity()?.to_mask(parray.len(), ctx)?;
+    let validity_mask = parray
+        .as_ref()
+        .validity()?
+        .execute_mask(parray.len(), ctx)?;
 
     let patches = if array_len < u8::MAX as usize {
         match_each_integer_ptype!(parray.ptype(), |T| {
@@ -316,7 +319,7 @@ fn bit_width_histogram_typed<T: NativePType + PrimInt>(
     let mut bit_widths = vec![0usize; size_of::<T>() * 8 + 1];
     match array
         .validity()?
-        .to_mask(array.as_ref().len(), ctx)?
+        .execute_mask(array.as_ref().len(), ctx)?
         .bit_buffer()
     {
         AllOr::All => {
@@ -477,7 +480,7 @@ mod test {
                 .as_ref()
                 .validity()
                 .unwrap()
-                .to_mask(compressed.as_ref().len(), &mut ctx)
+                .execute_mask(compressed.as_ref().len(), &mut ctx)
                 .unwrap()
                 .to_bit_buffer()
                 .set_indices()

encodings/fastlanes/src/bitpacking/array/bitpack_decompress.rs

@@ -58,7 +58,7 @@ pub(crate) fn unpack_into_primitive_builder<T: BitPackedUnpack>(
     // SAFETY: We later initialize the the uninitialized range of values with `copy_from_slice`.
     unsafe {
         // Append a dense null Mask.
-        uninit_range.append_mask(array.validity()?.to_mask(array.as_ref().len(), ctx)?);
+        uninit_range.append_mask(array.validity()?.execute_mask(array.as_ref().len(), ctx)?);
     }
 
     // SAFETY: `decode_into` will initialize all values in this range.

encodings/fastlanes/src/for/array/for_decompress.rs

@@ -109,7 +109,7 @@ pub(crate) fn fused_decompress<
     let mut uninit_range = builder.uninit_range(bp.len());
     unsafe {
         // Append a dense null Mask.
-        uninit_range.append_mask(bp.validity()?.to_mask(bp.as_ref().len(), ctx)?);
+        uninit_range.append_mask(bp.validity()?.execute_mask(bp.as_ref().len(), ctx)?);
     }
 
     // SAFETY: `decode_into` will initialize all values in this range.

encodings/fastlanes/src/rle/array/mod.rs

@@ -311,7 +311,7 @@ mod tests {
         let validity_mask = sliced_array
             .validity()
             .unwrap()
-            .to_mask(
+            .execute_mask(
                 sliced_array.len(),
                 &mut LEGACY_SESSION.create_execution_ctx(),
             )

encodings/fastlanes/src/rle/array/rle_decompress.rs

@@ -5,12 +5,10 @@ use fastlanes::RLE;
 use num_traits::AsPrimitive;
 use num_traits::NumCast;
 use vortex_array::ExecutionCtx;
-use vortex_array::IntoArray;
 use vortex_array::arrays::PrimitiveArray;
 use vortex_array::dtype::NativePType;
 use vortex_array::match_each_native_ptype;
 use vortex_array::match_each_unsigned_integer_ptype;
-use vortex_array::validity::Validity;
 use vortex_buffer::BufferMut;
 use vortex_error::VortexExpect;
 use vortex_error::VortexResult;
@@ -124,6 +122,6 @@ where
         buffer
             .freeze()
             .slice(offset_within_chunk..(offset_within_chunk + array.len())),
-        Validity::copy_from_array(&array.clone().into_array())?,
+        array.validity()?,
     ))
 }

encodings/fsst/src/array.rs

@@ -301,7 +301,7 @@ impl VTable for FSST {
             array
                 .array()
                 .validity()?
-                .to_mask(array.array().len(), ctx)?,
+                .execute_mask(array.array().len(), ctx)?,
         );
         Ok(())
     }