Skip to content

Commit c09b29d

Browse files
committed
Reuse fixed-width storage for decimal arrays
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent ced51f1 commit c09b29d

61 files changed

Lines changed: 594 additions & 615 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

fuzz/src/array/fill_null.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use vortex_array::arrays::DecimalArray;
1313
use vortex_array::arrays::PrimitiveArray;
1414
use vortex_array::arrays::VarBinViewArray;
1515
use vortex_array::arrays::bool::BoolArrayExt;
16+
use vortex_array::arrays::decimal::DecimalArrayExt;
1617
use vortex_array::builtins::ArrayBuiltins;
1718
use vortex_array::dtype::DType;
1819
use vortex_array::dtype::Nullability;

fuzz/src/array/mask.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ use vortex_array::arrays::PrimitiveArray;
1616
use vortex_array::arrays::StructArray;
1717
use vortex_array::arrays::VarBinViewArray;
1818
use vortex_array::arrays::bool::BoolArrayExt;
19+
use vortex_array::arrays::decimal::DecimalArrayExt;
1920
use vortex_array::arrays::extension::ExtensionArrayExt;
2021
use vortex_array::arrays::fixed_size_list::FixedSizeListArrayExt;
2122
use vortex_array::arrays::listview::ListViewArrayExt;

fuzz/src/array/scalar_at.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ use vortex_array::Canonical;
77
use vortex_array::ExecutionCtx;
88
use vortex_array::IntoArray;
99
use vortex_array::arrays::bool::BoolArrayExt;
10+
use vortex_array::arrays::decimal::DecimalArrayExt;
1011
use vortex_array::arrays::extension::ExtensionArrayExt;
1112
use vortex_array::arrays::fixed_size_list::FixedSizeListArrayExt;
1213
use vortex_array::arrays::listview::ListViewArrayExt;

vortex-array/src/aggregate_fn/fns/min_max/decimal.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ use super::MinMaxPartial;
99
use super::MinMaxResult;
1010
use crate::ExecutionCtx;
1111
use crate::arrays::DecimalArray;
12+
use crate::arrays::decimal::DecimalArrayExt;
1213
use crate::dtype::DecimalDType;
1314
use crate::dtype::NativeDecimalType;
1415
use crate::dtype::Nullability::NonNullable;

vortex-array/src/aggregate_fn/fns/sum/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,9 @@ impl AggregateFnVTable for Sum {
300300

301301
let result = match batch {
302302
Columnar::Canonical(c) => match c {
303-
Canonical::Primitive(p) => accumulate_primitive(&mut inner, p, ctx, skip_nans),
303+
Canonical::Primitive(a) => accumulate_primitive(&mut inner, a, ctx, skip_nans),
304+
Canonical::Decimal(a) => accumulate_decimal(&mut inner, a, ctx),
304305
Canonical::Bool(b) => accumulate_bool(&mut inner, b, ctx),
305-
Canonical::Decimal(d) => accumulate_decimal(&mut inner, d, ctx),
306306
_ => vortex_bail!("Unsupported canonical type for sum: {}", batch.dtype()),
307307
},
308308
Columnar::Constant(_) => unreachable!(),

0 commit comments

Comments
 (0)