File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -91,15 +91,15 @@ fn overlap_differential_exact_lower_than_estimate() -> VortexResult<()> {
9191}
9292
9393#[ test]
94- fn empty_elements_returns_zero ( ) -> VortexResult < ( ) > {
94+ fn empty_elements_returns_one ( ) -> VortexResult < ( ) > {
9595 let mut ctx = test_execution_ctx ( ) ;
9696 let lv = create_empty_elements_listview ( ) ;
9797
9898 let exact = lv. compute_density ( & mut ctx) ?;
9999 let est = lv. estimate_density ( & mut ctx) ?;
100100
101- assert ! ( exact. abs( ) < EPS ) ;
102- assert ! ( est. abs( ) < EPS ) ;
101+ assert ! ( ( exact - 1.0 ) . abs( ) < EPS ) ;
102+ assert ! ( ( est - 1.0 ) . abs( ) < EPS ) ;
103103 Ok ( ( ) )
104104}
105105
Original file line number Diff line number Diff line change @@ -154,7 +154,7 @@ impl StatsSetRef<'_> {
154154 }
155155
156156 /// Returns the value of `stat` by either fetching it from cache if it exists and is [`Precision::Exact`], or falling back to
157- /// computation.
157+ /// computation. The underlying compute kernels will cache the computed stat in the latter case.
158158 pub fn compute_stat ( & self , stat : Stat , ctx : & mut ExecutionCtx ) -> VortexResult < Option < Scalar > > {
159159 // If it's already computed and exact, we can return it.
160160 if let Some ( Precision :: Exact ( s) ) = self . get ( stat) {
You can’t perform that action at this time.
0 commit comments