address comments

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Author: connortsui20

vortex-tensor/src/fixed_shape/vtable.rs

@@ -22,7 +22,7 @@ impl ExtVTable for FixedShapeTensor {
     type NativeValue<'a> = &'a ScalarValue;
 
     fn id(&self) -> ExtId {
-        ExtId::new_ref("vortex.fixed_shape_tensor")
+        ExtId::new_ref("vortex.tensor.fixed_shape_tensor")
     }
 
     fn serialize_metadata(&self, metadata: &Self::Metadata) -> VortexResult<Vec<u8>> {

vortex-tensor/src/scalar_fns/cosine_similarity.rs

@@ -16,7 +16,6 @@ use vortex::array::match_each_float_ptype;
 use vortex::dtype::DType;
 use vortex::dtype::NativePType;
 use vortex::dtype::Nullability;
-use vortex::dtype::extension::Matcher;
 use vortex::error::VortexResult;
 use vortex::error::vortex_ensure;
 use vortex::error::vortex_ensure_eq;
@@ -53,7 +52,7 @@ impl ScalarFnVTable for CosineSimilarity {
     type Options = EmptyOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.cosine_similarity")
+        ScalarFnId::new_ref("vortex.tensor.cosine_similarity")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {
@@ -106,7 +105,7 @@ impl ScalarFnVTable for CosineSimilarity {
         })?;
 
         vortex_ensure!(
-            AnyTensor::matches(lhs_ext),
+            lhs_ext.is::<AnyTensor>(),
             "CosineSimilarity inputs must be an `AnyTensor`, got {lhs}"
         );
 

vortex-tensor/src/scalar_fns/l2_norm.rs

@@ -16,7 +16,6 @@ use vortex::array::match_each_float_ptype;
 use vortex::dtype::DType;
 use vortex::dtype::NativePType;
 use vortex::dtype::Nullability;
-use vortex::dtype::extension::Matcher;
 use vortex::error::VortexResult;
 use vortex::error::vortex_ensure;
 use vortex::error::vortex_ensure_eq;
@@ -48,7 +47,7 @@ impl ScalarFnVTable for L2Norm {
     type Options = EmptyOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.l2_norm")
+        ScalarFnId::new_ref("vortex.tensor.l2_norm")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {
@@ -89,7 +88,7 @@ impl ScalarFnVTable for L2Norm {
         })?;
 
         vortex_ensure!(
-            AnyTensor::matches(ext),
+            ext.is::<AnyTensor>(),
             "L2Norm input must be an `AnyTensor`, got {input_dtype}"
         );
 

vortex-tensor/src/vector/vtable.rs

@@ -20,7 +20,7 @@ impl ExtVTable for Vector {
     type NativeValue<'a> = &'a ScalarValue;
 
     fn id(&self) -> ExtId {
-        ExtId::new_ref("vortex.vector")
+        ExtId::new_ref("vortex.tensor.vector")
     }
 
     fn serialize_metadata(&self, _metadata: &Self::Metadata) -> VortexResult<Vec<u8>> {