MinMaxAggregateFn

Signed-off-by: Nicholas Gates <nick@nickgates.com>

Author: gatesn

encodings/runend/public-api.lock

@@ -44,10 +44,6 @@ pub fn vortex_runend::RunEnd::is_sorted(&self, array: &vortex_runend::RunEndArra
 
 pub fn vortex_runend::RunEnd::is_strict_sorted(&self, array: &vortex_runend::RunEndArray) -> vortex_error::VortexResult<core::option::Option<bool>>
 
-impl vortex_array::compute::min_max::MinMaxKernel for vortex_runend::RunEnd
-
-pub fn vortex_runend::RunEnd::min_max(&self, array: &vortex_runend::RunEndArray) -> vortex_error::VortexResult<core::option::Option<vortex_array::compute::min_max::MinMaxResult>>
-
 impl vortex_array::scalar_fn::fns::binary::compare::CompareKernel for vortex_runend::RunEnd
 
 pub fn vortex_runend::RunEnd::compare(lhs: &vortex_runend::RunEndArray, rhs: &vortex_array::array::ArrayRef, operator: vortex_array::scalar_fn::fns::operators::CompareOperator, ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::array::ArrayRef>>

encodings/runend/src/compute/min_max.rs

@@ -7,7 +7,6 @@ mod fill_null;
 pub(crate) mod filter;
 mod is_constant;
 mod is_sorted;
-mod min_max;
 pub(crate) mod take;
 pub(crate) mod take_from;
 

encodings/runend/src/compute/mod.rs

@@ -28,10 +28,6 @@ pub fn vortex_sequence::Sequence::is_sorted(&self, array: &vortex_sequence::Sequ
 
 pub fn vortex_sequence::Sequence::is_strict_sorted(&self, array: &vortex_sequence::SequenceArray) -> vortex_error::VortexResult<core::option::Option<bool>>
 
-impl vortex_array::compute::min_max::MinMaxKernel for vortex_sequence::Sequence
-
-pub fn vortex_sequence::Sequence::min_max(&self, array: &vortex_sequence::SequenceArray) -> vortex_error::VortexResult<core::option::Option<vortex_array::compute::min_max::MinMaxResult>>
-
 impl vortex_array::scalar_fn::fns::binary::compare::CompareKernel for vortex_sequence::Sequence
 
 pub fn vortex_sequence::Sequence::compare(lhs: &vortex_sequence::SequenceArray, rhs: &vortex_array::array::ArrayRef, operator: vortex_array::scalar_fn::fns::operators::CompareOperator, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<core::option::Option<vortex_array::array::ArrayRef>>

encodings/sequence/public-api.lock

@@ -6,7 +6,6 @@ pub(crate) mod compare;
 mod filter;
 mod is_sorted;
 mod list_contains;
-mod min_max;
 mod slice;
 mod take;
 

encodings/sequence/src/compute/min_max.rs

@@ -2,13 +2,16 @@
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
 use vortex_array::Canonical;
+use vortex_array::ExecutionCtx;
 use vortex_array::IntoArray as _;
-use vortex_array::compute::MinMaxResult;
-use vortex_array::compute::min_max;
+use vortex_array::aggregate_fn::fns::min_max::MinMaxResult;
+use vortex_array::aggregate_fn::fns::min_max::min_max;
 use vortex_error::VortexResult;
 
 /// Compute min_max on the canonical form of the array to get a consistent baseline.
-pub fn min_max_canonical_array(canonical: Canonical) -> VortexResult<Option<MinMaxResult>> {
-    // TODO(joe): replace with baseline not using canonical
-    min_max(&canonical.into_array())
+pub fn min_max_canonical_array(
+    canonical: Canonical,
+    ctx: &mut ExecutionCtx,
+) -> VortexResult<Option<MinMaxResult>> {
+    min_max(&canonical.into_array(), ctx)
 }

encodings/sequence/src/compute/mod.rs

@@ -43,13 +43,13 @@ use vortex_array::ArrayRef;
 use vortex_array::DynArray;
 use vortex_array::IntoArray;
 use vortex_array::VortexSessionExecute;
+use vortex_array::aggregate_fn::fns::min_max::MinMaxResult;
+use vortex_array::aggregate_fn::fns::min_max::min_max;
 use vortex_array::aggregate_fn::fns::sum::sum;
 use vortex_array::arrays::ConstantArray;
 use vortex_array::arrays::PrimitiveArray;
 use vortex_array::arrays::arbitrary::ArbitraryArray;
 use vortex_array::builtins::ArrayBuiltins;
-use vortex_array::compute::MinMaxResult;
-use vortex_array::compute::min_max;
 use vortex_array::dtype::DType;
 use vortex_array::dtype::Nullability;
 use vortex_array::scalar::Scalar;
@@ -345,6 +345,7 @@ impl<'a> Arbitrary<'a> for FuzzArrayAction {
                         current_array
                             .to_canonical()
                             .vortex_expect("to_canonical should succeed in fuzz test"),
+                        &mut ctx,
                     )
                     .vortex_expect("min_max_canonical_array should succeed in fuzz test");
                     (Action::MinMax, ExpectedValue::MinMax(min_max_result))
@@ -652,7 +653,7 @@ pub fn run_fuzz_action(fuzz_action: FuzzArrayAction) -> VortexFuzzResult<bool> {
                 assert_scalar_eq(&expected.scalar(), &sum_result, i)?;
             }
             Action::MinMax => {
-                let min_max_result = min_max(&current_array)
+                let min_max_result = min_max(&current_array, &mut ctx)
                     .vortex_expect("min_max operation should succeed in fuzz test");
                 assert_min_max_eq(&expected.min_max(), &min_max_result, i)?;
             }

fuzz/src/array/min_max.rs

@@ -12,7 +12,7 @@ use std::fmt::Formatter;
 
 use vortex_array::ArrayRef;
 use vortex_array::DynArray;
-use vortex_array::compute::MinMaxResult;
+use vortex_array::aggregate_fn::fns::min_max::MinMaxResult;
 use vortex_array::scalar::Scalar;
 use vortex_array::search_sorted::SearchResult;
 use vortex_array::search_sorted::SearchSortedSide;