u

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

encodings/fastlanes/src/delta/array/delta_compress.rs

@@ -18,15 +18,14 @@ use vortex_error::VortexResult;
 
 use crate::FL_CHUNK_SIZE;
 use crate::bit_transpose::transpose_validity;
-use crate::delta::array::unsigned_counterpart;
 use crate::fill_forward_nulls;
 pub fn delta_compress(
     array: &PrimitiveArray,
     ctx: &mut ExecutionCtx,
 ) -> VortexResult<(PrimitiveArray, PrimitiveArray)> {
     let validity = array.validity()?;
     let original_ptype = array.ptype();
-    let unsigned_ptype = unsigned_counterpart(original_ptype);
+    let unsigned_ptype = original_ptype.to_unsigned();
     // Signed integers are processed through their unsigned counterpart: `wrapping_sub`
     // is bit-identical for signed and unsigned operands, so the encoded bytes are the
     // same regardless of how the buffer's elements are interpreted.

encodings/fastlanes/src/delta/array/delta_decompress.rs

@@ -20,7 +20,6 @@ use vortex_error::VortexResult;
 use crate::DeltaArray;
 use crate::bit_transpose::untranspose_validity;
 use crate::delta::array::DeltaArrayExt;
-use crate::delta::array::unsigned_counterpart;
 
 pub fn delta_decompress(
     array: &DeltaArray,
@@ -36,7 +35,7 @@ pub fn delta_decompress(
     let validity = validity.slice(start..end)?;
 
     let original_ptype = deltas.ptype();
-    let unsigned_ptype = unsigned_counterpart(original_ptype);
+    let unsigned_ptype = original_ptype.to_unsigned();
     // Signed inputs are processed through their unsigned counterpart; `wrapping_add` on the
     // raw bytes inverts the `wrapping_sub` done at compress time regardless of signedness.
     let (bases, deltas) = if original_ptype == unsigned_ptype {

encodings/fastlanes/src/delta/array/mod.rs

@@ -116,22 +116,6 @@ impl DeltaData {
 }
 
 pub(crate) fn lane_count(ptype: PType) -> usize {
-    match_each_unsigned_integer_ptype!(unsigned_counterpart(ptype), |T| { T::LANES })
+    match_each_unsigned_integer_ptype!(ptype.to_unsigned(), |T| { T::LANES })
 }
 
-/// Map a signed integer [`PType`] to its same-width unsigned counterpart; other [`PType`]s
-/// pass through unchanged.
-///
-/// The FastLanes kernels (`Delta::delta`, `Transpose::transpose`, ...) are only implemented
-/// for unsigned integer types. Signed inputs are processed by viewing the same bytes through
-/// the unsigned counterpart; `wrapping_sub` / `wrapping_add` are bit-identical for signed and
-/// unsigned operands under two's-complement, so the round-trip is exact.
-pub(crate) fn unsigned_counterpart(ptype: PType) -> PType {
-    match ptype {
-        PType::I8 => PType::U8,
-        PType::I16 => PType::U16,
-        PType::I32 => PType::U32,
-        PType::I64 => PType::U64,
-        other => other,
-    }
-}