Merge remote-tracking branch 'origin/develop' into ngates/array-vtables-view2

Author: gatesn

.github/workflows/ci.yml

@@ -746,7 +746,7 @@ jobs:
           tool: cargo-codspeed
       - name: Build benchmarks
         env:
-          RUSTFLAGS: "-C target-feature=+avx2 -C debug-assertions=yes"
+          RUSTFLAGS: "-C target-feature=+avx2"
         run: cargo codspeed build ${{ matrix.features }} $(printf -- '-p %s ' ${{ matrix.packages }}) --profile bench
       - name: Run benchmarks
         uses: CodSpeedHQ/action@d872884a306dd4853acf0f584f4b706cf0cc72a2

vortex-array/src/arrays/fixed_size_list/tests/take.rs

@@ -11,7 +11,6 @@ use super::common::create_nullable_fsl;
 use super::common::create_single_element_fsl;
 use crate::ArrayRef;
 use crate::IntoArray;
-use crate::ToCanonical;
 use crate::arrays::FixedSizeListArray;
 use crate::arrays::PrimitiveArray;
 use crate::assert_arrays_eq;
@@ -160,8 +159,8 @@ fn test_element_index_overflow(
     #[case] indices: ArrayRef,
     #[case] expected: FixedSizeListArray,
 ) {
-    let result = fsl.take(indices).unwrap().to_fixed_size_list();
-    assert_arrays_eq!(expected, result);
+    let result = fsl.take(indices).unwrap();
+    assert_arrays_eq!(result, expected);
 }
 
 // Parameterized test for nullable array scenarios that are specific to FSL's implementation.

vortex-layout/src/layouts/buffered.rs

@@ -71,9 +71,7 @@ impl LayoutStrategy for BufferedStrategy {
                 if stream.as_mut().peek().await.is_none() {
                     let mut sequence_ptr = sequence_id.descend();
                     while let Some(chunk) = chunks.pop_front() {
-                        let chunk_size = chunk.nbytes();
-                        nbytes -= chunk_size;
-                        buffered_bytes_counter.fetch_sub(chunk_size, Ordering::Relaxed);
+                        buffered_bytes_counter.fetch_sub(chunk.nbytes(), Ordering::Relaxed);
                         yield (sequence_ptr.advance(), chunk)
                     }
                     break;