Slots

Signed-off-by: Nicholas Gates <nick@nickgates.com>

Author: gatesn

encodings/alp/src/alp_rd/array.rs

@@ -236,11 +236,11 @@ impl VTable for ALPRD {
         let ptype = dtype.as_ptype();
 
         let left_parts = left_parts
-            .try_into::<Primitive>()
+            .try_downcast::<Primitive>()
             .ok()
             .vortex_expect("ALPRD execute: left_parts is primitive");
         let right_parts = right_parts
-            .try_into::<Primitive>()
+            .try_downcast::<Primitive>()
             .ok()
             .vortex_expect("ALPRD execute: right_parts is primitive");
 

encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs

@@ -6,6 +6,7 @@ use itertools::Itertools;
 use num_traits::PrimInt;
 use vortex_array::IntoArray;
 use vortex_array::arrays::PrimitiveArray;
+use vortex_array::arrays::primitive::PrimitiveArrayExt;
 use vortex_array::buffer::BufferHandle;
 use vortex_array::dtype::IntegerPType;
 use vortex_array::dtype::NativePType;

encodings/fastlanes/src/bitpacking/array/mod.rs

@@ -299,7 +299,7 @@ impl BitPackedData {
     pub fn encode(array: &ArrayRef, bit_width: u8) -> VortexResult<BitPackedArray> {
         let parray: PrimitiveArray = array
             .clone()
-            .try_into::<Primitive>()
+            .try_downcast::<Primitive>()
             .map_err(|a| vortex_err!(InvalidArgument: "Bitpacking can only encode primitive arrays, got {}", a.encoding_id()))?;
         bitpack_encode(&parray, bit_width, None)
     }

encodings/fastlanes/src/for/array/for_compress.rs

@@ -52,6 +52,7 @@ mod test {
     use itertools::Itertools;
     use vortex_array::ToCanonical;
     use vortex_array::VortexSessionExecute;
+    use vortex_array::arrays::primitive::PrimitiveArrayExt;
     use vortex_array::assert_arrays_eq;
     use vortex_array::dtype::PType;
     use vortex_array::expr::stats::StatsProvider;

encodings/fastlanes/src/rle/array/mod.rs

@@ -234,6 +234,7 @@ mod tests {
     use vortex_array::ToCanonical;
     use vortex_array::VortexSessionExecute;
     use vortex_array::arrays::PrimitiveArray;
+    use vortex_array::arrays::primitive::PrimitiveArrayExt;
     use vortex_array::assert_arrays_eq;
     use vortex_array::dtype::DType;
     use vortex_array::dtype::Nullability;

encodings/fsst/src/compute/filter.rs

@@ -26,7 +26,7 @@ impl FilterKernel for FSST {
         let filtered_codes_ref = <VarBin as FilterKernel>::filter(codes, mask, ctx)?
             .vortex_expect("VarBin filter kernel always returns Some");
         let filtered_codes = filtered_codes_ref
-            .try_into::<VarBin>()
+            .try_downcast::<VarBin>()
             .ok()
             .vortex_expect("must be VarBin");
 

encodings/fsst/src/compute/mod.rs

@@ -41,7 +41,7 @@ impl TakeExecute for FSST {
                     <VarBin as TakeExecute>::take(codes, indices, _ctx)?
                         .vortex_expect("VarBin take kernel always returns Some")
                 }
-                .try_into::<VarBin>()
+                .try_downcast::<VarBin>()
                 .map_err(|_| vortex_err!("take for codes must return varbin array"))?,
                 array
                     .uncompressed_lengths()

encodings/fsst/src/slice.rs

@@ -26,7 +26,7 @@ impl SliceReduce for FSST {
                     array
                         .codes()
                         .slice(range.clone())?
-                        .try_into::<VarBin>()
+                        .try_downcast::<VarBin>()
                         .map_err(|_| vortex_err!("cannot fail conversion"))?,
                     array.uncompressed_lengths().slice(range)?,
                 )

encodings/pco/src/array.rs

@@ -469,7 +469,7 @@ impl PcoData {
     }
 
     pub fn from_array(array: ArrayRef, level: usize, nums_per_page: usize) -> VortexResult<Self> {
-        let parray = array.try_into::<Primitive>().map_err(|a| {
+        let parray = array.try_downcast::<Primitive>().map_err(|a| {
             vortex_err!(
                 "Pco can only encode primitive arrays, got {}",
                 a.encoding_id()

encodings/runend/src/arrow.rs

@@ -6,6 +6,7 @@ use arrow_array::types::RunEndIndexType;
 use vortex_array::ArrayRef;
 use vortex_array::IntoArray;
 use vortex_array::arrays::PrimitiveArray;
+use vortex_array::arrays::primitive::PrimitiveArrayExt;
 use vortex_array::arrow::FromArrowArray;
 use vortex_array::dtype::NativePType;
 use vortex_array::scalar::PValue;
@@ -76,6 +77,7 @@ mod tests {
     use vortex_array::IntoArray as _;
     use vortex_array::VortexSessionExecute as _;
     use vortex_array::arrays::PrimitiveArray;
+    use vortex_array::arrays::primitive::PrimitiveArrayExt;
     use vortex_array::arrow::ArrowArrayExecutor;
     use vortex_array::arrow::FromArrowArray;
     use vortex_array::assert_arrays_eq;