Skip to content

Commit d08c89b

Browse files
Suppress -Wtype-limits warning in DuckDB C++ compilation (#6957)
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a13c10a commit d08c89b

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

vortex-duckdb/build.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,14 @@ fn c2rust(crate_dir: &Path, duckdb_include_dir: &Path) {
325325
fn cpp(duckdb_include_dir: &Path) {
326326
cc::Build::new()
327327
.std("c++20")
328-
// Duckdb sources fail -Wno-unused-parameter
329-
.flags(["-Wall", "-Wextra", "-Wpedantic", "-Wno-unused-parameter"])
328+
// Duckdb sources fail -Wno-unused-parameter and -Wno-type-limits
329+
.flags([
330+
"-Wall",
331+
"-Wextra",
332+
"-Wpedantic",
333+
"-Wno-unused-parameter",
334+
"-Wno-type-limits",
335+
])
330336
.cpp(true)
331337
.include(duckdb_include_dir)
332338
.include("cpp/include")

vortex-duckdb/cpp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ if (NOT CMAKE_BUILD_TYPE)
2323
endif()
2424

2525
# Enable compiler warnings (matching build.rs flags).
26-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic")
26+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wno-type-limits")
2727

2828
# Find DuckDB include directory via the symlink created by build.rs.
2929
# The symlink points to target/duckdb-source-vX.Y.Z which contains duckdb-X.Y.Z/

0 commit comments

Comments
 (0)