Skip to content

Commit d2a8db2

Browse files
joseph-isaacsclaude
andcommitted
Fix vortex-cuda build: use HashSet<ArrayId> instead of ArrayRegistry
The NormalizeOptions API expects HashSet<Id>, not ArrayRegistry. Update CudaFlatLayoutStrategy to match. Also clean up unused imports in strategy.rs from the merge. Signed-off-by: Joe Isaacs <joe@spiraldb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent b1a491d commit d2a8db2

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vortex-cuda/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ vortex-cub = { path = "cub" }
4141
vortex-cuda-macros = { workspace = true }
4242
vortex-error = { workspace = true, features = ["object_store"] }
4343
vortex-nvcomp = { path = "nvcomp" }
44+
vortex-utils = { workspace = true }
4445

4546
[dev-dependencies]
4647
criterion = { package = "codspeed-criterion-compat-walltime", version = "4.3.0" }

vortex-cuda/src/layout.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use futures::FutureExt;
1414
use futures::StreamExt;
1515
use futures::future::BoxFuture;
1616
use vortex::array::ArrayContext;
17+
use vortex::array::ArrayId;
1718
use vortex::array::ArrayRef;
1819
use vortex::array::DeserializeMetadata;
1920
use vortex::array::MaskFuture;
@@ -28,7 +29,6 @@ use vortex::array::normalize::NormalizeOptions;
2829
use vortex::array::normalize::Operation;
2930
use vortex::array::serde::SerializeOptions;
3031
use vortex::array::serde::SerializedArray;
31-
use vortex::array::session::ArrayRegistry;
3232
use vortex::array::stats::StatsSetRef;
3333
use vortex::buffer::BufferString;
3434
use vortex::buffer::ByteBuffer;
@@ -63,6 +63,7 @@ use vortex::scalar::upper_bound;
6363
use vortex::session::VortexSession;
6464
use vortex::session::registry::ReadContext;
6565
use vortex::utils::aliases::hash_map::HashMap;
66+
use vortex_utils::aliases::hash_set::HashSet;
6667

6768
/// A buffer inlined into layout metadata for host-side access.
6869
#[derive(Clone, prost::Message)]
@@ -390,7 +391,7 @@ pub struct CudaFlatLayoutStrategy {
390391
/// Maximum length of variable length statistics.
391392
pub max_variable_length_statistics_size: usize,
392393
/// Optional set of allowed array encodings for normalization.
393-
pub allowed_encodings: Option<ArrayRegistry>,
394+
pub allowed_encodings: Option<HashSet<ArrayId>>,
394395
}
395396

396397
impl Default for CudaFlatLayoutStrategy {
@@ -414,7 +415,7 @@ impl CudaFlatLayoutStrategy {
414415
self
415416
}
416417

417-
pub fn with_allow_encodings(mut self, allow_encodings: ArrayRegistry) -> Self {
418+
pub fn with_allow_encodings(mut self, allow_encodings: HashSet<ArrayId>) -> Self {
418419
self.allowed_encodings = Some(allow_encodings);
419420
self
420421
}

vortex-file/src/strategy.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,8 @@ use vortex_sparse::Sparse;
5959
#[cfg(feature = "unstable_encodings")]
6060
use vortex_tensor::encodings::turboquant::TurboQuant;
6161
use vortex_utils::aliases::hash_map::HashMap;
62-
use vortex_zigzag::ZigZag;
63-
64-
6562
use vortex_utils::aliases::hash_set::HashSet;
63+
use vortex_zigzag::ZigZag;
6664
#[cfg(feature = "zstd")]
6765
use vortex_zstd::Zstd;
6866
#[cfg(all(feature = "zstd", feature = "unstable_encodings"))]

0 commit comments

Comments
 (0)