skip[clippy]: add some more hints (#7713)

requires these clippy lints:
```toml
redundant_static_lifetimes = "deny"
ref_binding_to_reference = "deny"
ref_patterns = "deny"
repeat_vec_with_capacity = "deny"
reserve_after_initialization = "deny"
```

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

Cargo.toml

@@ -352,6 +352,11 @@ panic = "deny"
 # panic_in_result_fn = "deny" -- we cannot disable this for tests to use assertions
 clone_on_ref_ptr = "deny"
 redundant_clone = "deny"
+redundant_static_lifetimes = "deny"
+ref_binding_to_reference = "deny"
+ref_patterns = "deny"
+repeat_vec_with_capacity = "deny"
+reserve_after_initialization = "deny"
 same_name_method = "deny"
 tests_outside_test_module = "deny"
 # todo = "deny"

encodings/alp/src/alp/decompress.rs

@@ -31,20 +31,20 @@ pub fn decompress_into_array(
 ) -> VortexResult<PrimitiveArray> {
     let dtype = array.dtype().clone();
     let (encoded, exponents, patches) = ALPArrayOwnedExt::into_parts(array);
-    if let Some(ref patches) = patches
-        && let Some(chunk_offsets) = patches.chunk_offsets()
+    if let Some(p) = &patches
+        && let Some(chunk_offsets) = p.chunk_offsets()
     {
         let prim_encoded = encoded.execute::<PrimitiveArray>(ctx)?;
         let patches_chunk_offsets = chunk_offsets.clone().execute::<PrimitiveArray>(ctx)?;
-        let patches_indices = patches.indices().clone().execute::<PrimitiveArray>(ctx)?;
-        let patches_values = patches.values().clone().execute::<PrimitiveArray>(ctx)?;
+        let patches_indices = p.indices().clone().execute::<PrimitiveArray>(ctx)?;
+        let patches_values = p.values().clone().execute::<PrimitiveArray>(ctx)?;
         Ok(decompress_chunked_core(
             prim_encoded,
             exponents,
             &patches_indices,
             &patches_values,
             &patches_chunk_offsets,
-            patches,
+            p,
             dtype,
         ))
     } else {
@@ -64,21 +64,21 @@ pub fn decompress_into_array(
 pub fn execute_decompress(array: ALPArray, ctx: &mut ExecutionCtx) -> VortexResult<PrimitiveArray> {
     let dtype = array.dtype().clone();
     let (encoded, exponents, patches) = ALPArrayOwnedExt::into_parts(array);
-    if let Some(ref patches) = patches
-        && let Some(chunk_offsets) = patches.chunk_offsets()
+    if let Some(p) = &patches
+        && let Some(chunk_offsets) = p.chunk_offsets()
     {
         // TODO(joe): have into parts.
         let encoded = encoded.execute::<PrimitiveArray>(ctx)?;
         let patches_chunk_offsets = chunk_offsets.clone().execute::<PrimitiveArray>(ctx)?;
-        let patches_indices = patches.indices().clone().execute::<PrimitiveArray>(ctx)?;
-        let patches_values = patches.values().clone().execute::<PrimitiveArray>(ctx)?;
+        let patches_indices = p.indices().clone().execute::<PrimitiveArray>(ctx)?;
+        let patches_values = p.values().clone().execute::<PrimitiveArray>(ctx)?;
         Ok(decompress_chunked_core(
             encoded,
             exponents,
             &patches_indices,
             &patches_values,
             &patches_chunk_offsets,
-            patches,
+            p,
             dtype,
         ))
     } else {

encodings/fastlanes/src/bitpacking/array/bitpack_decompress.rs

@@ -67,8 +67,8 @@ pub(crate) fn unpack_into_primitive_builder<T: BitPackedUnpack>(
     let mut bit_packed_iter = array.unpacked_chunks()?;
     bit_packed_iter.decode_into(uninit_slice);
 
-    if let Some(ref patches) = array.patches() {
-        apply_patches_to_uninit_range(&mut uninit_range, patches, ctx)?;
+    if let Some(patches) = array.patches() {
+        apply_patches_to_uninit_range(&mut uninit_range, &patches, ctx)?;
     };
 
     // SAFETY: We have set a correct validity mask via `append_mask` with `array.len()` values and

encodings/fastlanes/src/for/array/for_decompress.rs

@@ -118,10 +118,10 @@ pub(crate) fn fused_decompress<
     // Decode all chunks (initial, full, and trailer) in one call.
     unpacked.decode_into(uninit_slice);
 
-    if let Some(ref patches) = bp.patches() {
+    if let Some(patches) = bp.patches() {
         bitpack_decompress::apply_patches_to_uninit_range_fn(
             &mut uninit_range,
-            patches,
+            &patches,
             ctx,
             |v| v.wrapping_add(&ref_),
         )?;

vortex-array/src/aggregate_fn/fns/is_sorted/mod.rs

@@ -304,8 +304,8 @@ impl AggregateFnVTable for IsSorted {
         }
 
         // Check boundary: self.last_value vs other.first_value
-        if let Some(ref self_last) = partial.last_value
-            && let Some(ref other_first_val) = other_first
+        if let Some(self_last) = &partial.last_value
+            && let Some(other_first_val) = &other_first
         {
             if !self_last.is_null() && !other_first_val.is_null() {
                 let boundary_ok = if partial.strict {
@@ -404,7 +404,7 @@ impl AggregateFnVTable for IsSorted {
                 }
 
                 // Check boundary with previous chunk.
-                if let Some(ref self_last) = partial.last_value {
+                if let Some(self_last) = &partial.last_value {
                     if !self_last.is_null() && !value.is_null() {
                         let boundary_ok = if partial.strict {
                             *self_last < value
@@ -436,7 +436,7 @@ impl AggregateFnVTable for IsSorted {
 
                 // Check boundary with previous chunk.
                 let first_value = array_ref.execute_scalar(0, ctx)?.into_nullable();
-                if let Some(ref self_last) = partial.last_value {
+                if let Some(self_last) = &partial.last_value {
                     if !self_last.is_null() && !first_value.is_null() {
                         let boundary_ok = if partial.strict {
                             *self_last < first_value

vortex-array/src/aggregate_fn/fns/min_max/mod.rs

@@ -79,7 +79,7 @@ pub fn min_max(array: &ArrayRef, ctx: &mut ExecutionCtx) -> VortexResult<Option<
     let result = MinMaxResult::from_scalar(result_scalar)?;
 
     // Cache the computed min/max as statistics.
-    if let Some(ref r) = result {
+    if let Some(r) = &result {
         if let Some(min_value) = r.min.value() {
             array
                 .statistics()

vortex-array/src/arrays/dict/take.rs

@@ -100,7 +100,7 @@ where
             return Ok(Some(result));
         }
         let result = <V as TakeReduce>::take(array, parent.codes())?;
-        if let Some(ref taken) = result {
+        if let Some(taken) = &result {
             propagate_take_stats(array.array(), taken, parent.codes())?;
         }
         Ok(result)
@@ -131,7 +131,7 @@ where
             return Ok(Some(result));
         }
         let result = <V as TakeExecute>::take(array, parent.codes(), ctx)?;
-        if let Some(ref taken) = result {
+        if let Some(taken) = &result {
             propagate_take_stats(array.array(), taken, parent.codes())?;
         }
         Ok(result)

vortex-cuda/src/dynamic_dispatch/mod.rs

@@ -1942,7 +1942,7 @@ mod tests {
         )?
         .into_array();
 
-        let (array, base_offset) = if let Some(ref range) = slice_range {
+        let (array, base_offset) = if let Some(range) = &slice_range {
             (encoded.slice(range.clone())?, range.start)
         } else {
             (encoded, 0)
@@ -2696,7 +2696,7 @@ mod tests {
         )?
         .into_array();
 
-        let (array, base_offset) = if let Some(ref range) = slice_range {
+        let (array, base_offset) = if let Some(range) = &slice_range {
             (encoded.slice(range.clone())?, range.start)
         } else {
             (encoded, 0)

vortex-datafusion/src/persistent/source.rs

@@ -373,13 +373,13 @@ impl FileSource for VortexSource {
     fn fmt_extra(&self, t: DisplayFormatType, f: &mut Formatter) -> std::fmt::Result {
         match t {
             DisplayFormatType::Default | DisplayFormatType::Verbose => {
-                if let Some(ref predicate) = self.vortex_predicate {
+                if let Some(predicate) = &self.vortex_predicate {
                     write!(f, ", predicate: {predicate}")?;
                 }
             }
             // Use TreeRender style key=value formatting to display the predicate
             DisplayFormatType::TreeRender => {
-                if let Some(ref predicate) = self.vortex_predicate {
+                if let Some(predicate) = &self.vortex_predicate {
                     writeln!(f, "predicate={}", fmt_sql(predicate.as_ref()))?;
                 };
             }

vortex-datafusion/src/v2/source.rs

@@ -467,7 +467,7 @@ impl DataSource for VortexDataSource {
             "VortexScanSource: projection={}",
             self.projected_projection
         )?;
-        if let Some(ref filter) = self.filter {
+        if let Some(filter) = &self.filter {
             write!(f, ", filter={filter}")?;
         }
         if let Some(limit) = self.limit {