deprecate

Signed-off-by: Baris Palaska <barispalaska@gmail.com>

Author: palaska

encodings/parquet-variant/src/array.rs

@@ -14,7 +14,6 @@ use vortex_array::ArrayParts;
 use vortex_array::ArrayRef;
 use vortex_array::ExecutionCtx;
 use vortex_array::IntoArray;
-use vortex_array::LEGACY_SESSION;
 use vortex_array::TypedArrayRef;
 use vortex_array::arrays::VariantArray;
 use vortex_array::arrow::ArrowArrayExecutor;
@@ -184,20 +183,17 @@ impl ParquetVariantData {
                 }
             })
             .unwrap_or(Validity::NonNullable);
-        let metadata = ArrayRef::from_arrow(
-            arrow_variant.metadata_field() as &dyn ArrowArray,
-            false,
-            &LEGACY_SESSION,
-        )?;
+        let metadata =
+            ArrayRef::from_arrow(arrow_variant.metadata_field() as &dyn ArrowArray, false)?;
 
         let value = arrow_variant
             .value_field()
-            .map(|v| ArrayRef::from_arrow(v as &dyn ArrowArray, value_nullable, &LEGACY_SESSION))
+            .map(|v| ArrayRef::from_arrow(v as &dyn ArrowArray, value_nullable))
             .transpose()?;
 
         let typed_value = arrow_variant
             .typed_value_field()
-            .map(|tv| ArrayRef::from_arrow(tv.as_ref(), typed_value_nullable, &LEGACY_SESSION))
+            .map(|tv| ArrayRef::from_arrow(tv.as_ref(), typed_value_nullable))
             .transpose()?;
 
         let pv = ParquetVariant::try_new(validity, metadata, value, typed_value)?;

encodings/runend/public-api.lock

@@ -130,7 +130,7 @@ pub fn vortex_runend::RunEndData::array_hash<H: core::hash::Hasher>(&self, &mut
 
 impl<R: arrow_array::types::RunEndIndexType> vortex_array::arrow::FromArrowArray<&arrow_array::array::run_array::RunArray<R>> for vortex_runend::RunEndData where <R as arrow_array::types::ArrowPrimitiveType>::Native: vortex_array::dtype::ptype::NativePType
 
-pub fn vortex_runend::RunEndData::from_arrow(&arrow_array::array::run_array::RunArray<R>, bool, &vortex_session::VortexSession) -> vortex_error::VortexResult<Self>
+pub fn vortex_runend::RunEndData::from_arrow_with_session(&arrow_array::array::run_array::RunArray<R>, bool, &vortex_session::VortexSession) -> vortex_error::VortexResult<Self>
 
 pub struct vortex_runend::RunEndDataParts
 

encodings/runend/src/arrow.rs

@@ -26,7 +26,7 @@ impl<R: RunEndIndexType> FromArrowArray<&RunArray<R>> for RunEndData
 where
     R::Native: NativePType,
 {
-    fn from_arrow(
+    fn from_arrow_with_session(
         array: &RunArray<R>,
         nullable: bool,
         session: &VortexSession,
@@ -37,7 +37,7 @@ where
             Buffer::<R::Native>::from_arrow_scalar_buffer(array.run_ends().inner().clone());
         let ends = PrimitiveArray::new(ends_buf, Validity::NonNullable)
             .reinterpret_cast(R::Native::PTYPE.to_unsigned());
-        let values = ArrayRef::from_arrow(array.values().as_ref(), nullable, session)?;
+        let values = ArrayRef::from_arrow_with_session(array.values().as_ref(), nullable, session)?;
 
         let ends_array = PrimitiveArray::from_buffer_handle(
             ends.buffer_handle().clone(),
@@ -69,6 +69,7 @@ where
 }
 
 #[cfg(test)]
+#[allow(deprecated)]
 mod tests {
     use std::sync::Arc;
     use std::sync::LazyLock;
@@ -130,7 +131,7 @@ mod tests {
             Buffer::<R::Native>::from_arrow_scalar_buffer(array.run_ends().inner().clone());
         let ends = PrimitiveArray::new(ends_buf, Validity::NonNullable)
             .reinterpret_cast(R::Native::PTYPE.to_unsigned());
-        let values = ArrayRef::from_arrow(array.values().as_ref(), nullable, &SESSION)?;
+        let values = ArrayRef::from_arrow(array.values().as_ref(), nullable)?;
 
         let ends_array = PrimitiveArray::from_buffer_handle(
             ends.buffer_handle().clone(),

vortex-array/public-api.lock

@@ -37,11 +37,7 @@ fn arrow_filter_fn(array: &ArrayRef, mask: &Mask) -> vortex_error::VortexResult<
     let mask_array = BooleanArray::new(values.bit_buffer().clone().into(), None);
     let filtered = arrow_select::filter::filter(array_ref.as_ref(), &mask_array)?;
 
-    ArrayRef::from_arrow(
-        filtered.as_ref(),
-        array.dtype().is_nullable(),
-        &LEGACY_SESSION,
-    )
+    ArrayRef::from_arrow(filtered.as_ref(), array.dtype().is_nullable())
 }
 
 #[cfg(test)]