File tree Expand file tree Collapse file tree 4 files changed +3
-8
lines changed
Expand file tree Collapse file tree 4 files changed +3
-8
lines changed Original file line number Diff line number Diff line change @@ -19,9 +19,8 @@ use crate::scalar_fns::l2_denorm::normalize_as_l2_denorm;
1919pub struct L2DenormScheme ;
2020
2121impl Scheme for L2DenormScheme {
22- // TODO(connor): FIX THIS!!!
2322 fn scheme_name ( & self ) -> & ' static str {
24- "vortex.tensor.UNSTABLE. l2_denorm"
23+ "vortex.tensor.l2_denorm"
2524 }
2625
2726 fn matches ( & self , canonical : & Canonical ) -> bool {
Original file line number Diff line number Diff line change @@ -28,7 +28,6 @@ const CONVERGENCE_EPSILON: f64 = 1e-12;
2828/// Number of numerical integration points for computing conditional expectations.
2929const INTEGRATION_POINTS : usize = 1000 ;
3030
31- // TODO(connor): Maybe we should just store an `ArrayRef` here?
3231/// Global centroid cache keyed by (dimension, bit_width).
3332static CENTROID_CACHE : LazyLock < DashMap < ( u32 , u8 ) , Buffer < f32 > > > = LazyLock :: new ( DashMap :: default) ;
3433
Original file line number Diff line number Diff line change @@ -522,8 +522,7 @@ impl InnerProduct {
522522
523523 // Gate: u8 codes and f32 centroids.
524524 if codes_prim. ptype ( ) != PType :: U8 {
525- // TODO(connor): support wider code widths (u16, u32). TurboQuant only emits u8
526- // codes today, so this is the only path we need for now.
525+ // TODO(connor): Should we support wider codes?
527526 return Ok ( None ) ;
528527 }
529528 if values_prim. ptype ( ) != PType :: F32 {
Original file line number Diff line number Diff line change @@ -245,9 +245,7 @@ impl ScalarFnVTable for L2Denorm {
245245
246246 let flat = extract_flat_elements ( normalized. storage_array ( ) , tensor_flat_size, ctx) ?;
247247
248- // TODO(connor): Theoretically we could model this as a multiplication between the
249- // normalized array and a `RunEnd(Sequence(0, dimensions), norms)`. But since we have
250- // already canonicalized the array, it is probably not faster to do that.
248+ // TODO(connor): Do we want a "broadcast" expression for the List types, or is this fine?
251249 match_each_float_ptype ! ( flat. ptype( ) , |T | {
252250 let norms = norms. as_slice:: <T >( ) ;
253251
You can’t perform that action at this time.
0 commit comments