Skip to content

Commit da6549a

Browse files
committed
revert change
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
1 parent 05dcff9 commit da6549a

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

vortex-duckdb/src/datasource.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,17 +179,18 @@ fn progress(bytes_read: &AtomicU64, bytes_total: &AtomicU64) -> f64 {
179179

180180
impl ColumnStatistics {
181181
fn from(stats: &ColumnStatisticsAggregate, dtype: DType) -> Self {
182-
let min = stats.min.as_ref().and_then(|value| {
183-
Scalar::try_new(dtype.clone(), Some(value.clone()))
182+
let min = stats.min.as_ref().map(|value| {
183+
let value = value.clone();
184+
Scalar::try_new(dtype.clone(), Some(value))
184185
.vortex_expect("scalar dtype and value are incompatible")
185186
.try_to_duckdb_scalar()
186-
.ok()
187+
.vortex_expect("can't convert Scalar to duckdb Value")
187188
});
188-
let max = stats.max.as_ref().and_then(|value| {
189+
let max = stats.max.as_ref().map(|value| {
189190
Scalar::try_new(dtype.clone(), Some(value.clone()))
190191
.vortex_expect("scalar dtype and value are incompatible")
191192
.try_to_duckdb_scalar()
192-
.ok()
193+
.vortex_expect("can't convert Scalar to duckdb Value")
193194
});
194195

195196
let max_string_length = stats

0 commit comments

Comments
 (0)