Revert on-disk change

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

vortex-array/src/stats/flatbuffers.rs

@@ -47,7 +47,7 @@ impl WriteFlatBuffer for StatsSet {
                 fba::Precision::Inexact,
                 Some(fbb.create_vector(&ScalarValue::to_proto_bytes::<Vec<u8>>(Some(&min)))),
             ),
-            Precision::Absent => (fba::Precision::Absent, None),
+            Precision::Absent => (fba::Precision::Inexact, None),
         };
 
         let (max_precision, max) = match self.get(Stat::Max) {
@@ -59,7 +59,7 @@ impl WriteFlatBuffer for StatsSet {
                 fba::Precision::Inexact,
                 Some(fbb.create_vector(&ScalarValue::to_proto_bytes::<Vec<u8>>(Some(&max)))),
             ),
-            Precision::Absent => (fba::Precision::Absent, None),
+            Precision::Absent => (fba::Precision::Inexact, None),
         };
 
         let sum = self
@@ -132,11 +132,6 @@ impl StatsSet {
                     if let Some(max) = fb.max()
                         && let Some(stat_dtype) = stat_dtype
                     {
-                        let max_precision = fb.max_precision();
-                        if max_precision == fba::Precision::Absent {
-                            vortex_bail!("Corrupted max stat: value present with absent precision");
-                        }
-
                         let value =
                             ScalarValue::from_proto_bytes(max.bytes(), &stat_dtype, session)?;
                         let Some(value) = value else {
@@ -145,7 +140,7 @@ impl StatsSet {
 
                         stats_set.set(
                             Stat::Max,
-                            match max_precision {
+                            match fb.max_precision() {
                                 fba::Precision::Exact => Precision::Exact(value),
                                 fba::Precision::Inexact => Precision::Inexact(value),
                                 other => vortex_bail!("Corrupted max_precision field: {other:?}"),
@@ -157,11 +152,6 @@ impl StatsSet {
                     if let Some(min) = fb.min()
                         && let Some(stat_dtype) = stat_dtype
                     {
-                        let min_precision = fb.min_precision();
-                        if min_precision == fba::Precision::Absent {
-                            vortex_bail!("Corrupted min stat: value present with absent precision");
-                        }
-
                         let value =
                             ScalarValue::from_proto_bytes(min.bytes(), &stat_dtype, session)?;
                         let Some(value) = value else {
@@ -170,7 +160,7 @@ impl StatsSet {
 
                         stats_set.set(
                             Stat::Min,
-                            match min_precision {
+                            match fb.min_precision() {
                                 fba::Precision::Exact => Precision::Exact(value),
                                 fba::Precision::Inexact => Precision::Inexact(value),
                                 other => vortex_bail!("Corrupted min_precision field: {other:?}"),

vortex-flatbuffers/flatbuffers/vortex-array/array.fbs

@@ -40,7 +40,6 @@ table ArrayNode {
 enum Precision: uint8 {
     Inexact = 0,
     Exact = 1,
-    Absent = 2,
 }
 
 table ArrayStats {

vortex-flatbuffers/public-api.lock

@@ -450,8 +450,6 @@ pub fn vortex_flatbuffers::array::Compression::run_verifier(&mut flatbuffers::ve
 
 impl vortex_flatbuffers::array::Precision
 
-pub const vortex_flatbuffers::array::Precision::Absent: Self
-
 pub const vortex_flatbuffers::array::Precision::ENUM_MAX: u8
 
 pub const vortex_flatbuffers::array::Precision::ENUM_MIN: u8
@@ -534,7 +532,7 @@ pub const vortex_flatbuffers::array::ENUM_MIN_PRECISION: u8
 
 pub const vortex_flatbuffers::array::ENUM_VALUES_COMPRESSION: [vortex_flatbuffers::array::Compression; 2]
 
-pub const vortex_flatbuffers::array::ENUM_VALUES_PRECISION: [vortex_flatbuffers::array::Precision; 3]
+pub const vortex_flatbuffers::array::ENUM_VALUES_PRECISION: [vortex_flatbuffers::array::Precision; 2]
 
 pub fn vortex_flatbuffers::array::finish_array_buffer<'a, 'b, A: flatbuffers::builder::Allocator + 'a>(&'b mut flatbuffers::builder::FlatBufferBuilder<'a, A>, flatbuffers::primitives::WIPOffset<vortex_flatbuffers::array::Array<'a>>)
 

vortex-flatbuffers/src/generated/array.rs

@@ -91,13 +91,12 @@ impl ::flatbuffers::SimpleToVerifyInSlice for Compression {}
 #[deprecated(since = "2.0.0", note = "Use associated constants instead. This will no longer be generated in 2021.")]
 pub const ENUM_MIN_PRECISION: u8 = 0;
 #[deprecated(since = "2.0.0", note = "Use associated constants instead. This will no longer be generated in 2021.")]
-pub const ENUM_MAX_PRECISION: u8 = 2;
+pub const ENUM_MAX_PRECISION: u8 = 1;
 #[deprecated(since = "2.0.0", note = "Use associated constants instead. This will no longer be generated in 2021.")]
 #[allow(non_camel_case_types)]
-pub const ENUM_VALUES_PRECISION: [Precision; 3] = [
+pub const ENUM_VALUES_PRECISION: [Precision; 2] = [
   Precision::Inexact,
   Precision::Exact,
-  Precision::Absent,
 ];
 
 #[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash, Default)]
@@ -107,21 +106,18 @@ pub struct Precision(pub u8);
 impl Precision {
   pub const Inexact: Self = Self(0);
   pub const Exact: Self = Self(1);
-  pub const Absent: Self = Self(2);
 
   pub const ENUM_MIN: u8 = 0;
-  pub const ENUM_MAX: u8 = 2;
+  pub const ENUM_MAX: u8 = 1;
   pub const ENUM_VALUES: &'static [Self] = &[
     Self::Inexact,
     Self::Exact,
-    Self::Absent,
   ];
   /// Returns the variant's name or "" if unknown.
   pub fn variant_name(self) -> Option<&'static str> {
     match self {
       Self::Inexact => Some("Inexact"),
       Self::Exact => Some("Exact"),
-      Self::Absent => Some("Absent"),
       _ => None,
     }
   }

vortex-layout/src/display.rs

@@ -334,8 +334,8 @@ mod tests {
                     let expected = "\
 vortex.struct, dtype: {numbers=i64?, strings=utf8}, children: 2, rows: 5
 ├── numbers: vortex.chunked, dtype: i64?, children: 1, rows: 5
-│   └── [0]: vortex.flat, dtype: i64?, metadata: 187 bytes, rows: 5, segment 0, buffers=[40B, 1B], total=41B
-└── strings: vortex.flat, dtype: utf8, metadata: 122 bytes, rows: 5, segment 1, buffers=[43B, 80B], total=123B
+│   └── [0]: vortex.flat, dtype: i64?, metadata: 171 bytes, rows: 5, segment 0, buffers=[40B, 1B], total=41B
+└── strings: vortex.flat, dtype: utf8, metadata: 110 bytes, rows: 5, segment 1, buffers=[43B, 80B], total=123B
 ";
                     assert_eq!(output, expected);
                 })