Skip to content

Commit e03bd1d

Browse files
authored
Use vx-bench to run benchmarks in CI (#7466)
## Summary Use the same `vx-bench` tool we want to use locally to run the benchmarks in CI, removing bespoke bash argument parsing logic, generating data with it. --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent 61dffa9 commit e03bd1d

14 files changed

Lines changed: 1026 additions & 329 deletions

File tree

.github/scripts/run-sql-bench.sh

Lines changed: 0 additions & 141 deletions
This file was deleted.

.github/workflows/nightly-bench.yml

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,20 @@ jobs:
2929
"id": "tpch-nvme",
3030
"subcommand": "tpch",
3131
"name": "TPC-H on NVME",
32-
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex",
32+
"data_formats": ["parquet", "vortex"],
33+
"pr_targets": [
34+
{"engine": "datafusion", "format": "parquet"},
35+
{"engine": "datafusion", "format": "vortex"},
36+
{"engine": "duckdb", "format": "parquet"},
37+
{"engine": "duckdb", "format": "vortex"}
38+
],
39+
"develop_targets": [
40+
{"engine": "datafusion", "format": "parquet"},
41+
{"engine": "datafusion", "format": "vortex"},
42+
{"engine": "datafusion", "format": "lance"},
43+
{"engine": "duckdb", "format": "parquet"},
44+
{"engine": "duckdb", "format": "vortex"}
45+
],
3346
"scale_factor": "100"
3447
},
3548
{
@@ -38,9 +51,21 @@ jobs:
3851
"name": "TPC-H on S3",
3952
"local_dir": "vortex-bench/data/tpch/100.0",
4053
"remote_storage": "s3://vortex-ci-benchmark-datasets/${{github.ref_name}}/${{github.run_id}}/tpch/100.0/",
41-
"targets": "datafusion:parquet,datafusion:vortex,duckdb:parquet,duckdb:vortex",
54+
"data_formats": ["parquet", "vortex"],
55+
"pr_targets": [
56+
{"engine": "datafusion", "format": "parquet"},
57+
{"engine": "datafusion", "format": "vortex"},
58+
{"engine": "duckdb", "format": "parquet"},
59+
{"engine": "duckdb", "format": "vortex"}
60+
],
61+
"develop_targets": [
62+
{"engine": "datafusion", "format": "parquet"},
63+
{"engine": "datafusion", "format": "vortex"},
64+
{"engine": "duckdb", "format": "parquet"},
65+
{"engine": "duckdb", "format": "vortex"}
66+
],
4267
"scale_factor": "100.0"
43-
},
68+
}
4469
]
4570
strategy:
4671
# A single run not should kill the others

0 commit comments

Comments
 (0)