Skip to content

Commit e1233db

Browse files
committed
ruff lint
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent a26f8e3 commit e1233db

4 files changed

Lines changed: 16 additions & 17 deletions

File tree

bench-orchestrator/bench_orchestrator/cli.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ def backends_for_engines(engines: list[Engine]) -> list[ExecutionBackend]:
9797
Engine.DUCKDB: Format.PARQUET,
9898
Engine.LANCE: Format.LANCE,
9999
}
100-
return list(group_targets_by_backend(BenchmarkTarget(engine=engine, format=seed_formats[engine]) for engine in engines))
100+
return list(
101+
group_targets_by_backend(BenchmarkTarget(engine=engine, format=seed_formats[engine]) for engine in engines)
102+
)
101103

102104

103105
@contextmanager
@@ -288,10 +290,12 @@ def run(
288290
samply=samply,
289291
sample_rate=sample_rate,
290292
tracing=tracing,
291-
on_result=lambda line, store_writer=ctx.write_raw_json, compatibility=compatibility_file: write_result_line(
292-
line,
293-
store_writer,
294-
compatibility,
293+
on_result=lambda line, store_writer=ctx.write_raw_json, compatibility=compatibility_file: (
294+
write_result_line(
295+
line,
296+
store_writer,
297+
compatibility,
298+
)
295299
),
296300
)
297301
console.print(f"[green]{backend.value}: {len(results)} results[/green]")
@@ -540,8 +544,7 @@ def show(
540544
console.print(f" Formats: {', '.join(metadata.formats)}")
541545
if metadata.targets:
542546
console.print(
543-
" Targets: "
544-
+ ", ".join(f"{target['engine']}:{target['format']}" for target in metadata.targets)
547+
" Targets: " + ", ".join(f"{target['engine']}:{target['format']}" for target in metadata.targets)
545548
)
546549
console.print(f" Iterations: {metadata.iterations}")
547550
console.print(f" Git commit: {metadata.git_commit[:8]}")

bench-orchestrator/bench_orchestrator/config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,9 @@ def parse_formats_json(value: str) -> list[Format]:
180180
return _unique_preserve_order(formats)
181181

182182

183-
def resolve_axis_targets(engines: Iterable[Engine], formats: Iterable[Format]) -> tuple[list[BenchmarkTarget], list[str]]:
183+
def resolve_axis_targets(
184+
engines: Iterable[Engine], formats: Iterable[Format]
185+
) -> tuple[list[BenchmarkTarget], list[str]]:
184186
"""Expand engine/format axes into supported explicit targets."""
185187
warnings: list[str] = []
186188
targets: list[BenchmarkTarget] = []

bench-orchestrator/tests/test_cli.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22
# SPDX-FileCopyrightText: Copyright the Vortex contributors
33

44
import json
5-
from pathlib import Path
6-
7-
from typer.testing import CliRunner
85

96
from bench_orchestrator import cli as cli_module
107
from bench_orchestrator.runner.executor import BenchmarkExecutor
118
from bench_orchestrator.storage.store import ResultStore
9+
from typer.testing import CliRunner
1210

1311
runner = CliRunner()
1412

bench-orchestrator/tests/test_config.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515

1616

1717
def test_parse_targets_json_normalizes_and_dedupes_lance_targets() -> None:
18-
targets = parse_targets_json(
19-
'[{"engine":"lance","format":"lance"},{"engine":"datafusion","format":"lance"}]'
20-
)
18+
targets = parse_targets_json('[{"engine":"lance","format":"lance"},{"engine":"datafusion","format":"lance"}]')
2119

2220
assert targets == [BenchmarkTarget(engine=Engine.DATAFUSION, format=Format.LANCE)]
2321

@@ -65,6 +63,4 @@ def test_group_targets_by_backend_routes_lance_to_lance_binary() -> None:
6563
ExecutionBackend.LANCE,
6664
ExecutionBackend.DUCKDB,
6765
]
68-
assert groups[ExecutionBackend.LANCE] == [
69-
BenchmarkTarget(engine=Engine.DATAFUSION, format=Format.LANCE)
70-
]
66+
assert groups[ExecutionBackend.LANCE] == [BenchmarkTarget(engine=Engine.DATAFUSION, format=Format.LANCE)]

0 commit comments

Comments
 (0)