Merge remote-tracking branch 'origin/develop' into ji/all-around-cdtx

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/src/arrays/primitive/compute/cast.rs

Author: joseph-isaacs

.cargo/config.toml

@@ -3,9 +3,6 @@ rustflags = [
     "-C", "force-frame-pointers=yes",
 ]
 
-[target.wasm32-unknown-unknown]
-rustflags = ['--cfg', 'getrandom_backend="wasm_js"', '-C', 'target-feature=+atomics']
-
 [alias]
 xtask = "run -p xtask --"
 vx = "run -p vortex-tui --"

.github/scripts/run-sql-bench.sh

@@ -22,6 +22,9 @@
 
 set -Eeu -o pipefail
 
+export VORTEX_EXPERIMENTAL_PATCHED_ARRAY=1
+export FLAT_LAYOUT_INLINE_ARRAY_NODE=1
+
 subcommand="$1"
 targets="$2"
 shift 2

.github/workflows/bench-pr.yml

@@ -60,7 +60,7 @@ jobs:
         env:
           RUSTFLAGS: "-C target-cpu=native"
         run: |
-          cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
+          cargo build --package ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
 
       - name: Setup Polar Signals
         if: github.event.pull_request.head.repo.fork == false
@@ -76,6 +76,8 @@ jobs:
         shell: bash
         env:
           RUST_BACKTRACE: full
+          VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
+          FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
         run: |
           bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o results.json
 

.github/workflows/bench.yml

@@ -38,6 +38,7 @@ jobs:
           && format('runs-on={0}/runner=bench-dedicated/extras=s3-cache/tag={1}', github.run_id, matrix.benchmark.id)
           || 'ubuntu-latest' }}
     strategy:
+      fail-fast: false
       matrix:
         benchmark:
           - id: random-access-bench
@@ -73,7 +74,7 @@ jobs:
         env:
           RUSTFLAGS: "-C target-cpu=native"
         run: |
-          cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }}
+          cargo build --bin ${{ matrix.benchmark.id }} --profile release_debug ${{ matrix.benchmark.build_args }} --features unstable_encodings
 
       - name: Setup Polar Signals
         uses: polarsignals/gh-actions-ps-profiling@v0.8.1
@@ -88,6 +89,8 @@ jobs:
         shell: bash
         env:
           RUST_BACKTRACE: full
+          VORTEX_EXPERIMENTAL_PATCHED_ARRAY: "1"
+          FLAT_LAYOUT_INLINE_ARRAY_NODE: "1"
         run: |
           bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json
 

.github/workflows/ci.yml

@@ -203,7 +203,7 @@ jobs:
             runner: amd64-medium
             target: wasm32-unknown-unknown
             env:
-              rustflags: "RUSTFLAGS='-A warnings'"
+              rustflags: "RUSTFLAGS='-A warnings --cfg getrandom_backend=\"unsupported\"'"
             args: "--target wasm32-unknown-unknown --exclude vortex --exclude vortex-cuda --exclude vortex-cub --exclude vortex-nvcomp --exclude vortex-datafusion --exclude vortex-duckdb --exclude vortex-tui --exclude vortex-zstd --exclude vortex-test-e2e-cuda --exclude vortex-sqllogictest"
     steps:
       - uses: runs-on/action@v2

.github/workflows/sql-benchmarks.yml

@@ -144,7 +144,7 @@ jobs:
           if [ "${{ matrix.build_lance }}" = "true" ]; then
             packages="$packages --bin lance-bench"
           fi
-          cargo build $packages --profile release_debug
+          cargo build $packages --profile release_debug --features unstable_encodings
 
       - name: Generate data
         shell: bash

.github/workflows/stale.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/stale@v10
         with:
           # After 30 days of no activity, a PR will be marked as stale
-          days-before-pr-stale: 30
+          days-before-pr-stale: 14
           # PR has 7 more days to become active, otherwise it will be closed.
           days-before-pr-close: 7
           stale-pr-label: "stale"

Cargo.lock

@@ -163,6 +163,7 @@ itertools = "0.14.0"
 jetscii = "0.5.3"
 jiff = "0.2.0"
 kanal = "0.1.1"
+lasso = { version = "0.7", features = ["multi-threaded"] }
 lending-iterator = "0.1.7"
 libfuzzer-sys = "0.4"
 libloading = "0.8"
@@ -302,11 +303,6 @@ vortex-duckdb = { path = "./vortex-duckdb", default-features = false }
 vortex-test-e2e-cuda = { path = "./vortex-test/e2e-cuda", default-features = false }
 vortex-tui = { path = "./vortex-tui" }
 
-[workspace.dependencies.getrandom_v03]
-features = ["wasm_js"]
-package = "getrandom"
-version = "0.4.0"
-
 [workspace.lints.rust]
 let_underscore_drop = "deny"
 macro_use_extern_crate = "deny"

Cargo.toml

@@ -34,6 +34,7 @@ vortex-bench = { workspace = true }
 
 [features]
 lance = ["dep:lance-bench"]
+unstable_encodings = ["vortex/unstable_encodings"]
 
 [lints]
 workspace = true