Skip to content

Commit e99ba67

Browse files
committed
Fix CI: enable test editions in new footer-metadata tests, rustdoc links, Python goldens
The develop merge brought in the file-level metadata tests (#8740), which write with bare sessions that enable no editions and now fail validation. Enable the crate's test edition in those sessions, matching the other vortex-file unit tests. Also re-qualify the vortex::editions module-doc links (module docs resolve at the lib.rs `pub mod` site) and update the Python doctest golden file sizes for the edition-derived footer context. Signed-off-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CK2nCuXnyd2g3mNHQC8Lz2
1 parent 51a8f52 commit e99ba67

4 files changed

Lines changed: 11 additions & 6 deletions

File tree

vortex-file/src/multi/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ mod tests {
341341
.with::<RuntimeSession>()
342342
.with::<MultiFileSession>();
343343
crate::register_default_encodings(&session);
344+
crate::enable_all_registered_array_encodings(&session);
344345

345346
let expected = ByteBuffer::copy_from(b"cached metadata");
346347
let mut output = ByteBufferMut::empty();
@@ -441,6 +442,7 @@ mod tests {
441442
.with::<RuntimeSession>()
442443
.with::<MultiFileSession>();
443444
crate::register_default_encodings(&session);
445+
crate::enable_all_registered_array_encodings(&session);
444446

445447
let mut out_a = ByteBufferMut::empty();
446448
session

vortex-file/src/open.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -648,6 +648,7 @@ mod tests {
648648
.with::<LayoutSession>()
649649
.with::<RuntimeSession>();
650650
crate::register_default_encodings(&session);
651+
crate::enable_all_registered_array_encodings(&session);
651652

652653
let metadata = ByteBuffer::copy_from(vec![0x5a; INITIAL_READ_SIZE * 2]);
653654
let mut output = ByteBufferMut::empty();
@@ -721,6 +722,7 @@ mod tests {
721722
.with::<LayoutSession>()
722723
.with::<RuntimeSession>();
723724
crate::register_default_encodings(&session);
725+
crate::enable_all_registered_array_encodings(&session);
724726

725727
let value = ByteBuffer::copy_from(b"supplied-footer metadata");
726728
let mut output = ByteBufferMut::empty();

vortex-python/src/io.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ impl PyVortexWriteOptions {
258258
/// >>> vx.io.VortexWriteOptions.default().write(sprl, "chonky.vortex")
259259
/// >>> import os
260260
/// >>> os.path.getsize('chonky.vortex')
261-
/// 215940
261+
/// 215900
262262
///
263263
/// Wow, Vortex manages to use about two bytes per integer! So advanced. So tiny.
264264
///
@@ -268,7 +268,7 @@ impl PyVortexWriteOptions {
268268
///
269269
/// >>> vx.io.VortexWriteOptions.compact().write(sprl, "tiny.vortex")
270270
/// >>> os.path.getsize('tiny.vortex')
271-
/// 55068
271+
/// 55028
272272
///
273273
/// Random numbers are not (usually) composed of random bytes!
274274
#[staticmethod]

vortex/src/editions/mod.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@
55
//!
66
//! [`vortex_edition`] provides the types, session variables, and test harness. The actual
77
//! first-party declarations live here, one module per edition. The default session first
8-
//! registers them with [`register_default_editions`] and then selects its write policy with
9-
//! [`enable_default_editions`].
8+
//! registers them with [`crate::editions::register_default_editions`] and then selects its
9+
//! write policy with [`crate::editions::enable_default_editions`].
1010
//!
1111
//! The default file writer resolves the session's enabled editions at write time. The
12-
//! facade enables the newest frozen `core` edition, [`CORE_2026_07_0`], and additionally
13-
//! enables the latest unstable edition when the `unstable_encodings` feature is selected.
12+
//! facade enables the newest frozen `core` edition, [`crate::editions::CORE_2026_07_0`],
13+
//! and additionally enables the latest unstable edition when the `unstable_encodings`
14+
//! feature is selected.
1415
1516
pub mod core;
1617
#[cfg(test)]

0 commit comments

Comments
 (0)