Skip to content

Commit ef8eaf1

Browse files
committed
some more stuff
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1 parent 87412e2 commit ef8eaf1

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

encodings/parquet-variant/public-api.lock

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pub type vortex_parquet_variant::ParquetVariant::Metadata = vortex_parquet_varia
1818

1919
pub type vortex_parquet_variant::ParquetVariant::OperationsVTable = vortex_parquet_variant::ParquetVariant
2020

21-
pub type vortex_parquet_variant::ParquetVariant::ValidityVTable = vortex_parquet_variant::ParquetVariant
21+
pub type vortex_parquet_variant::ParquetVariant::ValidityVTable = vortex_array::vtable::validity::ValidityVTableFromValidityHelper
2222

2323
pub fn vortex_parquet_variant::ParquetVariant::array_eq(array: &vortex_parquet_variant::ParquetVariantArray, other: &vortex_parquet_variant::ParquetVariantArray, precision: vortex_array::hash::Precision) -> bool
2424

@@ -62,10 +62,6 @@ impl vortex_array::vtable::operations::OperationsVTable<vortex_parquet_variant::
6262

6363
pub fn vortex_parquet_variant::ParquetVariant::scalar_at(array: &vortex_parquet_variant::ParquetVariantArray, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
6464

65-
impl vortex_array::vtable::validity::ValidityVTable<vortex_parquet_variant::ParquetVariant> for vortex_parquet_variant::ParquetVariant
66-
67-
pub fn vortex_parquet_variant::ParquetVariant::validity(array: &vortex_parquet_variant::ParquetVariantArray) -> vortex_error::VortexResult<vortex_array::validity::Validity>
68-
6965
pub struct vortex_parquet_variant::ParquetVariantArray
7066

7167
impl vortex_parquet_variant::ParquetVariantArray
@@ -82,8 +78,6 @@ pub fn vortex_parquet_variant::ParquetVariantArray::try_new_with_validity(validi
8278

8379
pub fn vortex_parquet_variant::ParquetVariantArray::typed_value_array(&self) -> core::option::Option<&vortex_array::array::ArrayRef>
8480

85-
pub fn vortex_parquet_variant::ParquetVariantArray::validity(&self) -> &vortex_array::validity::Validity
86-
8781
pub fn vortex_parquet_variant::ParquetVariantArray::value_array(&self) -> core::option::Option<&vortex_array::array::ArrayRef>
8882

8983
impl vortex_parquet_variant::ParquetVariantArray
@@ -116,6 +110,10 @@ impl vortex_array::array::IntoArray for vortex_parquet_variant::ParquetVariantAr
116110

117111
pub fn vortex_parquet_variant::ParquetVariantArray::into_array(self) -> vortex_array::array::ArrayRef
118112

113+
impl vortex_array::vtable::validity::ValidityHelper for vortex_parquet_variant::ParquetVariantArray
114+
115+
pub fn vortex_parquet_variant::ParquetVariantArray::validity(&self) -> &vortex_array::validity::Validity
116+
119117
pub struct vortex_parquet_variant::ParquetVariantMetadata
120118

121119
pub vortex_parquet_variant::ParquetVariantMetadata::has_value: bool

encodings/parquet-variant/src/vtable.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ use vortex_session::VortexSession;
3434

3535
use crate::array::ParquetVariantArray;
3636

37+
/// VTable for [`ParquetVariantArray`].
3738
#[derive(Debug)]
3839
pub struct ParquetVariant;
3940

0 commit comments

Comments
 (0)