fix

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/src/scalar/convert/from_scalar.rs

@@ -113,7 +113,10 @@ impl TryFrom<&Scalar> for bool {
     type Error = VortexError;
 
     fn try_from(value: &Scalar) -> VortexResult<Self> {
-        <Option<bool>>::try_from(value)?
+        value
+            .as_bool_opt()
+            .ok_or_else(|| vortex_err!("Expected bool scalar, found {}", value.dtype()))?
+            .value()
             .ok_or_else(|| vortex_err!("Can't extract present value from null scalar"))
     }
 }

vortex-array/src/vtable/mod.rs

@@ -255,15 +255,14 @@ pub fn child_to_validity(child: &Option<ArrayRef>, nullability: Nullability) ->
         Some(arr) => {
             // Detect constant bool arrays created by validity_to_child.
             // Use direct ScalarValue matching to avoid expensive scalar conversion.
-            if let Some(c) = arr.as_opt::<Constant>() {
-                if let Some(ScalarValue::Bool(val)) = c.scalar().value() {
+            if let Some(c) = arr.as_opt::<Constant>()
+                && let Some(ScalarValue::Bool(val)) = c.scalar().value() {
                     return if *val {
                         Validity::AllValid
                     } else {
                         Validity::AllInvalid
                     };
                 }
-            }
             Validity::Array(arr.clone())
         }
         None => Validity::from(nullability),