Skip to content

Commit f3331ad

Browse files
connortsui20claude
andcommitted
refactor(ci): resolve SQL benchmark matrices from profiles
Replace the duplicated full/base YAML matrices with a plan job that resolves the requested bench-orchestrator profile. Wire develop, PR, full-PR, and nightly callers to explicit profiles, derive remote paths from matrix metadata, and preserve the previous nightly iteration count. Build lance-bench whenever a resolved entry contains a Lance target so the full PR profile and its built backends stay consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent 04b3341 commit f3331ad

5 files changed

Lines changed: 51 additions & 567 deletions

File tree

.github/workflows/bench-pr.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,3 +141,4 @@ jobs:
141141
secrets: inherit
142142
with:
143143
mode: "pr"
144+
profile: "pr"

.github/workflows/bench.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,3 +171,4 @@ jobs:
171171
secrets: inherit
172172
with:
173173
mode: "develop"
174+
profile: "develop"

.github/workflows/nightly-bench.yml

Lines changed: 1 addition & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -23,49 +23,7 @@ jobs:
2323
with:
2424
mode: "develop"
2525
machine_type: ${{ matrix.machine_type.instance_name }}
26-
benchmark_matrix: |
27-
[
28-
{
29-
"id": "tpch-nvme",
30-
"subcommand": "tpch",
31-
"name": "TPC-H on NVME",
32-
"data_formats": ["parquet", "vortex"],
33-
"pr_targets": [
34-
{"engine": "datafusion", "format": "parquet"},
35-
{"engine": "datafusion", "format": "vortex"},
36-
{"engine": "duckdb", "format": "parquet"},
37-
{"engine": "duckdb", "format": "vortex"}
38-
],
39-
"develop_targets": [
40-
{"engine": "datafusion", "format": "parquet"},
41-
{"engine": "datafusion", "format": "vortex"},
42-
{"engine": "duckdb", "format": "parquet"},
43-
{"engine": "duckdb", "format": "vortex"}
44-
],
45-
"scale_factor": "100"
46-
},
47-
{
48-
"id": "tpch-s3",
49-
"subcommand": "tpch",
50-
"name": "TPC-H on S3",
51-
"local_dir": "vortex-bench/data/tpch/100.0",
52-
"remote_storage": "s3://vortex-ci-benchmark-datasets/${{github.ref_name}}/${{github.run_id}}/tpch/100.0/",
53-
"data_formats": ["parquet", "vortex"],
54-
"pr_targets": [
55-
{"engine": "datafusion", "format": "parquet"},
56-
{"engine": "datafusion", "format": "vortex"},
57-
{"engine": "duckdb", "format": "parquet"},
58-
{"engine": "duckdb", "format": "vortex"}
59-
],
60-
"develop_targets": [
61-
{"engine": "datafusion", "format": "parquet"},
62-
{"engine": "datafusion", "format": "vortex"},
63-
{"engine": "duckdb", "format": "parquet"},
64-
{"engine": "duckdb", "format": "vortex"}
65-
],
66-
"scale_factor": "100.0"
67-
}
68-
]
26+
profile: "nightly"
6927
strategy:
7028
# A single run not should kill the others
7129
fail-fast: false

0 commit comments

Comments
 (0)