Merge remote-tracking branch 'origin/develop' into ji/slots-for-arrays

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	encodings/decimal-byte-parts/src/decimal_byte_parts/compute/is_constant.rs
#	vortex-array/src/arrays/chunked/compute/aggregate.rs
#	vortex-array/src/arrays/chunked/compute/is_sorted.rs
#	vortex-array/src/arrays/chunked/compute/sum.rs

Author: joseph-isaacs

.github/actions/check-rebuild/action.yml

@@ -0,0 +1,23 @@
+name: "Build and verify rebuild is a no-op"
+description: "Run a cargo command, then re-run it to verify all artifacts are cached"
+inputs:
+  command:
+    description: "The cargo build command to run and verify (--message-format json is appended on the verification run)"
+    required: true
+runs:
+  using: "composite"
+  steps:
+    - name: "Build"
+      shell: bash
+      run: ${{ inputs.command }}
+    - name: "Verify rebuild is a no-op"
+      shell: bash
+      run: |
+        stale=$(${{ inputs.command }} \
+          --message-format json 2>/dev/null \
+          | jq -r 'select(.reason == "compiler-artifact" and .fresh == false) | .target.name')
+        if [ -n "$stale" ]; then
+          echo "ERROR: Rebuild recompiled crates that should have been cached:"
+          echo "$stale"
+          exit 1
+        fi

.github/actions/setup-prebuild/action.yml

@@ -1,15 +1,49 @@
 name: "Setup Prebuild"
-description: "Minimal setup for runners with pre-built Rust toolchain, nextest, and sccache"
+description: "Prebuild AMIs — uses pre-installed tools, falls back to full setup-rust for forks"
+
+inputs:
+  repo-token:
+    description: "GitHub token for accessing the repository (typically secrets.GITHUB_TOKEN)"
+    required: false
+    default: "${{ github.token }}"
+  toolchain:
+    description: "optional override for the toolchain version (e.g. nightly)"
+    required: false
+  components:
+    description: "optional override for the components to install for the step (e.g. clippy, rustfmt, miri)"
+    default: "clippy, rustfmt"
+    required: false
+  targets:
+    description: "optional targets override (e.g. wasm32-unknown-unknown)"
+    required: false
+  enable-sccache:
+    description: "Should sccache be enabled, true by default."
+    required: false
+    default: "true"
 
 runs:
   using: "composite"
   steps:
+    # Prebuild path: tools already installed, just configure sccache
     - name: Configure sccache timeout
+      if: github.repository == 'vortex-data/vortex' && inputs.enable-sccache == 'true'
       shell: bash
       run: |
         mkdir -p ~/.config/sccache
         echo 'server_startup_timeout_ms = 15000' > ~/.config/sccache/config
 
     - name: Pre-start sccache server
+      if: github.repository == 'vortex-data/vortex' && inputs.enable-sccache == 'true'
       shell: bash
       run: sccache --start-server &
+
+    # Fallback path: full setup for forks
+    - name: Full Rust setup
+      if: github.repository != 'vortex-data/vortex'
+      uses: ./.github/actions/setup-rust
+      with:
+        repo-token: ${{ inputs.repo-token }}
+        toolchain: ${{ inputs.toolchain }}
+        components: ${{ inputs.components }}
+        targets: ${{ inputs.targets }}
+        enable-sccache: ${{ inputs.enable-sccache }}

.github/actions/setup-rust/action.yml

@@ -85,7 +85,7 @@ runs:
       uses: ./.github/actions/setup-protoc
 
     - name: Install Ninja (for DuckDB build system)
-      uses: seanmiddleditch/gha-setup-ninja@master
+      uses: seanmiddleditch/gha-setup-ninja@v6
 
     - name: Install Sweep
       shell: bash

.github/scripts/fuzz_report/templates/new_issue.md

@@ -40,25 +40,33 @@ cargo +nightly fuzz run -D --sanitizer=none {{FUZZ_TARGET}} ./fuzz/artifacts/{{F
 ```
 
 <details>
-<summary>First-time setup: download and extract the crash artifact</summary>
+<summary>Reproduction Steps</summary>
 
-1. Download the crash artifact:
-   - **Direct download**: {{ARTIFACT_URL}}
-   - Extract the zip file (`unzip`)
-     - The path should look like `/path/to/{{FUZZ_TARGET}}/{{CRASH_FILE}}`
-     - You can create a `./fuzz/artifacts` directory that will be git-ignored in the `vortex` repo
-     - Full path would be `./fuzz/artifacts/{{FUZZ_TARGET}}/{{CRASH_FILE}}`
+1. Download the crash artifact: {{ARTIFACT_URL}}
 
 2. Assuming you download the zipfile to `~/Downloads`, and your working directory is the repository root:
 
 ```bash
+# Create the artifacts directory if you haven't already.
 mkdir -p ./fuzz/artifacts
+
+# Move the zipfile.
 mv ~/Downloads/{{FUZZ_TARGET}}-crash-artifacts.zip ./fuzz/artifacts/
+
+# Unzip the zipfile.
 unzip ./fuzz/artifacts/{{FUZZ_TARGET}}-crash-artifacts.zip -d ./fuzz/artifacts/
+
+# You can remove the zipfile now if you want to.
 rm ./fuzz/artifacts/{{FUZZ_TARGET}}-crash-artifacts.zip
 ```
 
-3. Get a backtrace:
+3. Reproduce the crash:
+
+```bash
+cargo +nightly fuzz run -D --sanitizer=none {{FUZZ_TARGET}} ./fuzz/artifacts/{{FUZZ_TARGET}}/{{CRASH_FILE}} -- -rss_limit_mb=0
+```
+
+If you want a backtrace:
 
 ```bash
 RUST_BACKTRACE=1 cargo +nightly fuzz run -D --sanitizer=none {{FUZZ_TARGET}} ./fuzz/artifacts/{{FUZZ_TARGET}}/{{CRASH_FILE}} -- -rss_limit_mb=0
@@ -70,6 +78,19 @@ RUST_BACKTRACE=full cargo +nightly fuzz run -D --sanitizer=none {{FUZZ_TARGET}}
 
 </details>
 
+<details>
+<summary>Single command to get a backtrace</summary>
+
+```bash
+mkdir -p ./fuzz/artifacts
+mv ~/Downloads/{{FUZZ_TARGET}}-crash-artifacts.zip ./fuzz/artifacts/
+unzip ./fuzz/artifacts/{{FUZZ_TARGET}}-crash-artifacts.zip -d ./fuzz/artifacts/
+rm ./fuzz/artifacts/{{FUZZ_TARGET}}-crash-artifacts.zip
+RUST_BACKTRACE=1 cargo +nightly fuzz run -D --sanitizer=none {{FUZZ_TARGET}} ./fuzz/artifacts/{{FUZZ_TARGET}}/{{CRASH_FILE}} -- -rss_limit_mb=0
+```
+
+</details>
+
 <!-- seed_hash:{{SEED_HASH}} stack_hash:{{STACK_TRACE_HASH}} message_hash:{{MESSAGE_HASH}} -->
 
 ---

.github/workflows/bench-pr.yml

@@ -97,7 +97,7 @@ jobs:
 
       - name: Setup AWS CLI
         if: github.event.pull_request.head.repo.fork == false
-        uses: aws-actions/configure-aws-credentials@v5
+        uses: aws-actions/configure-aws-credentials@v6
         with:
           role-to-assume: arn:aws:iam::245040174862:role/GitHubBenchmarkRole
           aws-region: us-east-1

.github/workflows/bench.yml

@@ -18,7 +18,7 @@ jobs:
     steps:
       - uses: actions/checkout@v6
       - name: Setup AWS CLI
-        uses: aws-actions/configure-aws-credentials@v5
+        uses: aws-actions/configure-aws-credentials@v6
         with:
           role-to-assume: arn:aws:iam::245040174862:role/GitHubBenchmarkRole
           aws-region: us-east-1
@@ -92,7 +92,7 @@ jobs:
           bash scripts/bench-taskset.sh target/release_debug/${{ matrix.benchmark.id }} --formats ${{ matrix.benchmark.formats }} -d gh-json -o results.json
 
       - name: Setup AWS CLI
-        uses: aws-actions/configure-aws-credentials@v5
+        uses: aws-actions/configure-aws-credentials@v6
         with:
           role-to-assume: arn:aws:iam::245040174862:role/GitHubBenchmarkRole
           aws-region: us-east-1