make not fallible

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Author: connortsui20

vortex-array/src/scalar_fn/vtable.rs

@@ -92,8 +92,6 @@ pub trait ScalarFnVTable: 'static + Sized + Clone + Send + Sync {
         Ok(args.to_vec())
     }
 
-    // TODO(connor): This needs a precondition for the number of args it has, or all implementations
-    // need to return an error if it is wrong.
     /// Compute the return [`DType`] of the expression if evaluated over the given input types.
     ///
     /// # Preconditions

vortex-tensor/src/scalar_fns/cosine_similarity.rs

@@ -18,7 +18,6 @@ use vortex::dtype::NativePType;
 use vortex::dtype::Nullability;
 use vortex::error::VortexResult;
 use vortex::error::vortex_ensure;
-use vortex::error::vortex_ensure_eq;
 use vortex::error::vortex_err;
 use vortex::expr::Expression;
 use vortex::scalar_fn::Arity;
@@ -81,13 +80,6 @@ impl ScalarFnVTable for CosineSimilarity {
     }
 
     fn return_dtype(&self, _options: &Self::Options, arg_dtypes: &[DType]) -> VortexResult<DType> {
-        vortex_ensure_eq!(
-            arg_dtypes.len(),
-            2,
-            "CosineSimilarity requires exactly 2 arguments, got {}",
-            arg_dtypes.len()
-        );
-
         let lhs = &arg_dtypes[0];
         let rhs = &arg_dtypes[1];
 

vortex-tensor/src/scalar_fns/l2_norm.rs

@@ -18,7 +18,6 @@ use vortex::dtype::NativePType;
 use vortex::dtype::Nullability;
 use vortex::error::VortexResult;
 use vortex::error::vortex_ensure;
-use vortex::error::vortex_ensure_eq;
 use vortex::error::vortex_err;
 use vortex::expr::Expression;
 use vortex::scalar_fn::Arity;
@@ -73,13 +72,6 @@ impl ScalarFnVTable for L2Norm {
     }
 
     fn return_dtype(&self, _options: &Self::Options, arg_dtypes: &[DType]) -> VortexResult<DType> {
-        vortex_ensure_eq!(
-            arg_dtypes.len(),
-            1,
-            "L2Norm requires exactly 2 arguments, got {}",
-            arg_dtypes.len()
-        );
-
         let input_dtype = &arg_dtypes[0];
 
         // Input must be a tensor-like extension type.
@@ -146,8 +138,7 @@ impl ScalarFnVTable for L2Norm {
     }
 
     fn is_fallible(&self, _options: &Self::Options) -> bool {
-        // Canonicalization of the storage array can fail.
-        true
+        false
     }
 }