WIP: Variant Type#6853
Closed
AdamGS wants to merge 14 commits into
Closed
Conversation
AdamGS
force-pushed
the
adamg/variant
branch
2 times, most recently
from
6ac96fe to
5306dd9
Compare
Merging this PR will degrade performance by 10.2%
Performance Changes
Comparing 
Footnotes
|
a10y
reviewed
Mar 10, 2026
| /// [`I32`]: PType::I32 | ||
| /// [`NonNullable`]: Nullability::NonNullable | ||
| #[derive(Debug, Clone, PartialEq, Eq, Hash)] | ||
| pub enum DType { |
Contributor
There was a problem hiding this comment.
do you think we should make this #[non_exhaustive] ?
Contributor
Author
There was a problem hiding this comment.
I think adding a new dtype should be very rare, but it is pretty painful to do right now.
AdamGS
force-pushed
the
adamg/variant
branch
3 times, most recently
from
83828b2 to
ff30b01
Compare
AdamGS
force-pushed
the
adamg/variant
branch
2 times, most recently
from
1b79bc4 to
74e1e04
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Author
|
Impl moved away from this branch, split it into multiple things and moved it elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just stashing results here to make the work more visible: