Type Coercion#6960
Merged
Merged
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Comment on lines
+52
to
+53
| if child_dtype.eq_ignore_nullability(target) | ||
| && child_dtype.nullability() == target.nullability() |
| return Some(self.with_nullability(self.nullability() | other.nullability())); | ||
| } | ||
|
|
||
| let union_null = self.nullability() | other.nullability(); |
connortsui20
approved these changes
Mar 13, 2026
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Contributor
|
We used to talk about expressions as being tightly typed and physical, this seems like a pretty big break from that? |
Member
|
I think we need to have the ability to upcast due to our type narrowing? I believe the idea is that we want the ability to do query planning within Vortex without relying on other systems, and in that case we need to know what is possible to coerce / cast. I guess it's an open question on if this is the right way to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows Vortex expressions to be typed in contexts that currently don't have their own logical planner, for example expressions passed into PyVortex.