Skip to content

Simplify returned value when chunked reader is asked to read empty range#7010

Merged
robert3005 merged 2 commits into
developfrom
rk/simplifychunkedemptylayout
Mar 18, 2026
Merged

Simplify returned value when chunked reader is asked to read empty range#7010
robert3005 merged 2 commits into
developfrom
rk/simplifychunkedemptylayout

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This was a little bit too complex given what we were trying to do

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Mar 18, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) March 18, 2026 18:24
@codspeed-hq

codspeed-hq Bot commented Mar 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.36%

⚡ 4 improved benchmarks
✅ 1005 untouched benchmarks
⏩ 1515 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation old_bp_prim_test_between[i64, 16384] 326.2 µs 294.4 µs +10.8%
Simulation old_bp_prim_test_between[i64, 32768] 538.7 µs 475.5 µs +13.29%
Simulation bitwise_not_vortex_buffer_mut[1024] 535.6 ns 477.2 ns +12.22%
Simulation bitwise_not_vortex_buffer_mut[128] 376.1 ns 317.8 ns +18.36%

Comparing rk/simplifychunkedemptylayout (7bca01d) with develop (6d6faf3)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 merged commit ddb3d39 into develop Mar 18, 2026
97 of 98 checks passed
@robert3005 robert3005 deleted the rk/simplifychunkedemptylayout branch March 18, 2026 18:41
dimitarvdimitrov pushed a commit that referenced this pull request Mar 20, 2026
…nge (#7010)

This was a little bit too complex given what we were trying to do

---------

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants