Skip to content

Simplify returned value when chunked reader is asked to read empty range #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 2 commits into from
Mar 18, 2026
Merged

Simplify returned value when chunked reader is asked to read empty range #7010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70834cd
Simplify returned value when chunked reader is asked to read empty range
robert3005 Mar 18, 2026
7bca01d
unused
robert3005 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vortex-layout/src/layouts/chunked/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use std::collections::BTreeSet;
use std::future;
use std::ops::Range;
use std::sync::Arc;

Expand All @@ -11,6 +12,7 @@ use futures::future::BoxFuture;
use futures::stream::FuturesOrdered;
use itertools::Itertools;
use vortex_array::ArrayRef;
use vortex_array::Canonical;
use vortex_array::IntoArray;
use vortex_array::MaskFuture;
use vortex_array::arrays::ChunkedArray;
Expand Down Expand Up @@ -293,9 +295,7 @@ impl LayoutReader for ChunkedReader {
) -> VortexResult<BoxFuture<'static, VortexResult<ArrayRef>>> {
let dtype = expr.return_dtype(self.dtype())?;
if row_range.is_empty() {
return Ok(
async move { Ok(ChunkedArray::try_new(vec![], dtype)?.into_array()) }.boxed(),
);
return Ok(future::ready(Ok(Canonical::empty(&dtype).into_array())).boxed());
}

let mut chunk_evals = vec![];
Expand Down
Loading