Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vortex-test/compat-gen/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,12 @@ Check modes:

| Mode | Extra files in dir | Missing fixtures |
|------|--------------------|------------------|
| `subset` (default) | Skipped | Error |
| `superset` (default) | Error | Skipped |
| `exact` | Error | Error |
| `superset` | Error | Skipped |
| `subset` | Skipped | Error |

Use `subset` when checking old versions (they may have extra fixtures not in
current code). Use `exact` for the current version.
Use `superset` when checking old versions (they may be missing newly-added
fixtures). Use `exact` for the current version.

## Python Orchestrator: `compat.py`

Expand Down
4 changes: 2 additions & 2 deletions vortex-test/compat-gen/scripts/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def cmd_check(args: argparse.Namespace) -> None:
total_failed += 1

_info(f" checking v{version}...")
result = _run_rust_check(tmppath, mode="subset", profile=args.profile)
result = _run_rust_check(tmppath, mode="superset", profile=args.profile)

passed = len(result.get("passed", []))
failed_list = result.get("failed", [])
Expand Down Expand Up @@ -822,7 +822,7 @@ def _run_rust_generate(output: Path, profile: str = "release") -> None:
_run_cmd([bin_path, "generate", "--output", str(output)], check=True)


def _run_rust_check(dir: Path, mode: str = "subset", profile: str = "release") -> dict:
def _run_rust_check(dir: Path, mode: str = "superset", profile: str = "release") -> dict:
"""Run `vortex-compat check --dir <dir> --mode <mode>` and parse JSON stdout."""
bin_path = _build_compat_bin(profile)
cmd = [bin_path, "check", "--dir", str(dir), "--mode", mode]
Expand Down
12 changes: 6 additions & 6 deletions vortex-test/compat-gen/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ EXAMPLES:\n\
Generate fixtures into a directory:\n\
vortex-compat generate --output /tmp/fixtures\n\
\n\
Check fixtures (allow extra files from older versions):\n\
vortex-compat check --dir /tmp/v0.62.0 --mode subset\n\
Check fixtures (default, old dir may be missing new fixtures):\n\
vortex-compat check --dir /tmp/v0.62.0\n\
\n\
Check fixtures (strict, must match exactly):\n\
vortex-compat check --dir /tmp/v0.63.0 --mode exact\n\
Expand Down Expand Up @@ -78,11 +78,11 @@ enum Commands {

/// How to handle mismatches between directory contents and known fixtures.
///
/// subset — directory may have extra files (skipped), all known must be present.
/// Best for checking old versions that may have since-removed fixtures.
/// exact — directory must match current fixtures 1:1. No extras, no missing.
/// superset — directory may be missing files (skipped), no unknown files allowed.
#[arg(long, default_value = "subset", value_name = "MODE")]
/// Best for checking old versions that predate newly-added fixtures.
/// exact — directory must match current fixtures 1:1. No extras, no missing.
/// subset — directory may have extra files (skipped), all known must be present.
#[arg(long, default_value = "superset", value_name = "MODE")]
mode: check::Mode,

/// Fixture name substrings to exclude from checking (comma-separated).
Expand Down
Loading