Skip to content

skip[fuzz]: remove undefined binary name#7139

Merged
joseph-isaacs merged 2 commits into
developfrom
ji/fix-fuzz-bin-name
Mar 24, 2026
Merged

skip[fuzz]: remove undefined binary name#7139
joseph-isaacs merged 2 commits into
developfrom
ji/fix-fuzz-bin-name

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Use a single binary with a different workflow name and feature flags.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	fuzz/Cargo.toml
@joseph-isaacs joseph-isaacs added changelog/fix A bug fix changelog/skip Do not list PR in the changelog labels Mar 24, 2026
@joseph-isaacs joseph-isaacs changed the title chore[fuzz]: remove undefined binary name skip[fuzz]: remove undefined binary name Mar 24, 2026
@joseph-isaacs joseph-isaacs requested a review from 0ax1 March 24, 2026 11:35
@joseph-isaacs joseph-isaacs marked this pull request as ready for review March 24, 2026 11:35
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) March 24, 2026 11:35
@codspeed-hq

codspeed-hq Bot commented Mar 24, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.36%

⚡ 2 improved benchmarks
✅ 1014 untouched benchmarks
⏩ 1522 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 376.1 ns 317.8 ns +18.36%
Simulation bitwise_not_vortex_buffer_mut[1024] 535.6 ns 477.2 ns +12.22%

Comparing ji/fix-fuzz-bin-name (1b45a67) with develop (5a11eee)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

description: "Display/storage name for this fuzz run. Defaults to fuzz_target if not set."
required: false
type: string
default: ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should default the target

@0ax1 0ax1 disabled auto-merge March 24, 2026 11:38
@0ax1

0ax1 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

One q, disabled auto-merge.

@joseph-isaacs joseph-isaacs removed the changelog/fix A bug fix label Mar 24, 2026
@joseph-isaacs joseph-isaacs merged commit 41616b4 into develop Mar 24, 2026
72 of 76 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fix-fuzz-bin-name branch March 24, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants