Skip to content

Make sure all tokio runtime propegate observability in the same way #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 1 commit into from
Mar 27, 2026
+3 −13
Merged

Make sure all tokio runtime propegate observability in the same way #7193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions vortex-io/src/runtime/tokio.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,23 +95,15 @@ struct CurrentTokioRuntime;

impl Executor for CurrentTokioRuntime {
fn spawn(&self, fut: BoxFuture<'static, ()>) -> AbortHandleRef {
Box::new(tokio::runtime::Handle::current().spawn(fut).abort_handle())
Executor::spawn(&tokio::runtime::Handle::current(), fut)
}

fn spawn_cpu(&self, cpu: Box<dyn FnOnce() + Send + 'static>) -> AbortHandleRef {
Box::new(
tokio::runtime::Handle::current()
.spawn(async move { cpu() })
.abort_handle(),
)
Executor::spawn_cpu(&tokio::runtime::Handle::current(), cpu)
}

fn spawn_blocking_io(&self, task: Box<dyn FnOnce() + Send + 'static>) -> AbortHandleRef {
Box::new(
tokio::runtime::Handle::current()
.spawn_blocking(task)
.abort_handle(),
)
Executor::spawn_blocking_io(&tokio::runtime::Handle::current(), task)
}
}

Expand Down Expand Up @@ -159,13 +151,11 @@ impl BlockingRuntime for TokioRuntime {
}
}

#[cfg(feature = "tokio")]
Comment thread
a10y marked this conversation as resolved.
pub struct TokioBlockingIterator<'a, T> {
handle: Arc<tokio::runtime::Handle>,
stream: futures::stream::BoxStream<'a, T>,
}

#[cfg(feature = "tokio")]
impl<T> Iterator for TokioBlockingIterator<'_, T> {
type Item = T;

Expand Down
Loading