Skip to content

fix: remove Arc double-wrapping in vortex-ffi apply and tests

900ad8a
Select commit
Loading
Failed to load commit list.
Merged

break: apply should use apply(self: Arc<Self>, ...) over apply(&self, ...) #7259

fix: remove Arc double-wrapping in vortex-ffi apply and tests
900ad8a
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Apr 2, 2026 in 0s

Performance Regression: -23.77%

❌ 24 regressed benchmarks
✅ 1098 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_search[(0.01, 0.1)] 272.7 µs 345.6 µs -21.1%
Simulation take_search[(0.005, 0.1)] 251.7 µs 324.6 µs -22.46%
Simulation take_search[(0.005, 0.05)] 135.8 µs 172.3 µs -21.18%
Simulation take_search[(0.005, 1.0)] 2.3 ms 3.1 ms -23.77%
Simulation take_search[(0.01, 1.0)] 2.5 ms 3.3 ms -22.31%
Simulation take_search[(0.005, 0.5)] 1.2 ms 1.5 ms -23.6%
Simulation take_search[(0.1, 0.05)] 217 µs 253.6 µs -14.4%
Simulation take_search[(0.01, 0.5)] 1.3 ms 1.6 ms -22.15%
Simulation take_search[(0.1, 0.5)] 1.8 ms 2.2 ms -16.91%
Simulation take_search[(0.1, 1.0)] 3.5 ms 4.3 ms -17.09%
Simulation take_search[(0.01, 0.05)] 147.2 µs 183.7 µs -19.86%
Simulation take_search_chunked[(0.005, 1.0)] 3 ms 3.6 ms -17.09%
Simulation take_search[(0.1, 0.1)] 391.4 µs 464.3 µs -15.71%
Simulation take_search_chunked[(0.005, 0.1)] 320 µs 381.9 µs -16.21%
Simulation take_search_chunked[(0.005, 0.05)] 170.9 µs 201.9 µs -15.34%
Simulation take_search_chunked[(0.01, 0.1)] 344.7 µs 406.6 µs -15.22%
Simulation take_search_chunked[(0.01, 0.5)] 1.6 ms 1.9 ms -15.93%
Simulation take_search_chunked[(0.01, 0.05)] 184 µs 214.9 µs -14.39%
Simulation take_search_chunked[(0.005, 0.5)] 1.5 ms 1.8 ms -16.98%
Simulation take_search_chunked[(0.01, 1.0)] 3.2 ms 3.9 ms -16.04%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/apply-fix (900ad8a) with develop (13937c0)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.