Closed
Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/lazy-patched
branch
from
0af3001 to
36e5ac9
Compare
gatesn
requested changes
Apr 6, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Don't we want to just replace e.g. fastlanes.bitpacked with a new deserializer that returns Patched(BitPacked) ?
Contributor
Author
|
what is a deserializer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step as part of replacing arrays with interior patches with wrapped PatchedArray in backward-compatible fashion.
We create a new wrapper array,
LazyPatchedArray. This only lives in-memory as an execution shim to bridge old-stylePatchesto new-stylePatchedArray.The follow up to this PR will update the
VTable::build()method to return ArrayRef, and update BitPacked::build() to return either BitPackedArray with interior Patches, or PatchedArray wrapping BitPacked, based on an experimental flag.