feat: First Last#7313
Merged
Merged
Conversation
Merging this PR will improve performance by 31.26%
Performance Changes
Comparing 
Footnotes
|
a10y
approved these changes
Apr 7, 2026
Comment on lines
+31
to
+36
| pub struct FirstPartial { | ||
| /// The nullable version of the input dtype, used for the result and for empty/all-null inputs. | ||
| return_dtype: DType, | ||
| /// The first non-null value seen so far, or `None` if no non-null value has been observed. | ||
| value: Option<Scalar>, | ||
| } |
Contributor
There was a problem hiding this comment.
why did you put this in partial and not options? Do you think we will never not know the dtype externally
Contributor
|
Can we merge this without serialise enabled in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.