Skip to content

block serialization for the existing aggregations#7322

Merged
blaginin merged 3 commits intodevelopfrom
db/block-serialization
Apr 7, 2026
Merged

block serialization for the existing aggregations#7322
blaginin merged 3 commits intodevelopfrom
db/block-serialization

Conversation

@blaginin
Copy link
Copy Markdown
Member

@blaginin blaginin commented Apr 7, 2026

No description provided.

Signed-off-by: blaginin <github@blaginin.me>
@blaginin blaginin requested a review from joseph-isaacs April 7, 2026 15:40
@blaginin blaginin self-assigned this Apr 7, 2026
@blaginin blaginin added the changelog/break A breaking API change label Apr 7, 2026
Ok(Some(vec![u8::from(options.strict)]))
}

fn deserialize(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will degrade performance by 23.82%

❌ 24 regressed benchmarks
✅ 1098 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_search[(0.005, 1.0)] 2.3 ms 3.1 ms -23.82%
Simulation take_search[(0.005, 0.1)] 246.7 µs 319.8 µs -22.85%
Simulation take_search[(0.01, 0.5)] 1.3 ms 1.6 ms -22.23%
Simulation take_search[(0.005, 0.05)] 131.2 µs 167.9 µs -21.85%
Simulation take_search[(0.01, 1.0)] 2.5 ms 3.3 ms -22.35%
Simulation take_search[(0.01, 0.1)] 267.5 µs 340.6 µs -21.46%
Simulation take_search[(0.005, 0.5)] 1.2 ms 1.5 ms -23.69%
Simulation take_search[(0.1, 0.1)] 386.1 µs 459.2 µs -15.92%
Simulation take_search[(0.1, 0.05)] 212.1 µs 248.8 µs -14.75%
Simulation take_search_chunked[(0.005, 0.5)] 1.5 ms 1.8 ms -17.04%
Simulation take_search_chunked[(0.005, 0.1)] 314.2 µs 376.4 µs -16.53%
Simulation take_search[(0.1, 0.5)] 1.8 ms 2.2 ms -16.96%
Simulation take_search_chunked[(0.005, 1.0)] 3 ms 3.6 ms -17.12%
Simulation take_search[(0.01, 0.05)] 142.3 µs 179 µs -20.5%
Simulation take_search_chunked[(0.01, 0.05)] 178.4 µs 209.7 µs -14.92%
Simulation take_search[(0.1, 1.0)] 3.5 ms 4.3 ms -17.11%
Simulation take_search_chunked[(0.01, 0.1)] 338.6 µs 400.8 µs -15.52%
Simulation take_search_chunked[(0.01, 1.0)] 3.2 ms 3.9 ms -16.07%
Simulation take_search_chunked[(0.01, 0.5)] 1.6 ms 1.9 ms -16%
Simulation take_search_chunked[(0.1, 0.05)] 244.3 µs 275.7 µs -11.38%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing db/block-serialization (9048158) with develop (29a5f43)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

blaginin added 2 commits April 7, 2026 17:24
Signed-off-by: blaginin <github@blaginin.me>
Signed-off-by: blaginin <github@blaginin.me>
@blaginin blaginin merged commit 9dcb75e into develop Apr 7, 2026
59 of 60 checks passed
@blaginin blaginin deleted the db/block-serialization branch April 7, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants