Skip to content

Unify id creation for ScalarFns and rename is_null to vortex.is_null#7325

Open
robert3005 wants to merge 1 commit intodevelopfrom
rk/names
Open

Unify id creation for ScalarFns and rename is_null to vortex.is_null#7325
robert3005 wants to merge 1 commit intodevelopfrom
rk/names

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

Use ScalarFnId::from instead of new_ref and rename is_null fn to vortex.is_null

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/break A breaking API change label Apr 7, 2026
@robert3005 robert3005 enabled auto-merge (squash) April 7, 2026 17:07
@robert3005 robert3005 added changelog/fix A bug fix changelog/break A breaking API change and removed changelog/break A breaking API change changelog/fix A bug fix labels Apr 7, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will degrade performance by 14.84%

❌ 1 regressed benchmark
✅ 1121 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 50.1 µs 58.8 µs -14.84%

Comparing rk/names (1c8bf29) with develop (06065ff)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be namespace these into vortex.scalar_fn... or something else?

Also while we are here what dynamic expr is this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, DynamicComparisonExpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants