Skip to content

Unify id creation for ScalarFns and rename is_null to vortex.is_null #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Apr 8, 2026
Merged

Unify id creation for ScalarFns and rename is_null to vortex.is_null #7325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/dynamic.rs
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be namespace these into vortex.scalar_fn... or something else?

Also while we are here what dynamic expr is this?

Copy link
Copy Markdown
Contributor Author

@robert3005 robert3005 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, DynamicComparisonExpr

Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl ScalarFnVTable for DynamicComparison {
type Options = DynamicComparisonExpr;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.dynamic")
ScalarFnId::from("vortex.dynamic")
}

fn arity(&self, _options: &Self::Options) -> Arity {
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/is_null.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ impl ScalarFnVTable for IsNull {
type Options = EmptyOptions;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("is_null")
ScalarFnId::from("vortex.is_null")
}

fn serialize(&self, _instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/literal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl ScalarFnVTable for Literal {
type Options = Scalar;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.literal")
ScalarFnId::from("vortex.literal")
}

fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/merge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ impl ScalarFnVTable for Merge {
type Options = DuplicateHandling;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.merge")
ScalarFnId::from("vortex.merge")
}

fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/pack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ impl ScalarFnVTable for Pack {
type Options = PackOptions;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.pack")
ScalarFnId::from("vortex.pack")
}

fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/scalar_fn/fns/select.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl ScalarFnVTable for Select {
type Options = FieldSelection;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.select")
ScalarFnId::from("vortex.select")
}

fn serialize(&self, instance: &FieldSelection) -> VortexResult<Option<Vec<u8>>> {
Expand Down
2 changes: 1 addition & 1 deletion vortex-tensor/src/scalar_fns/cosine_similarity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ impl ScalarFnVTable for CosineSimilarity {
type Options = ApproxOptions;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.tensor.cosine_similarity")
ScalarFnId::from("vortex.tensor.cosine_similarity")
}

fn arity(&self, _options: &Self::Options) -> Arity {
Expand Down
2 changes: 1 addition & 1 deletion vortex-tensor/src/scalar_fns/inner_product.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ impl ScalarFnVTable for InnerProduct {
type Options = ApproxOptions;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.tensor.inner_product")
ScalarFnId::from("vortex.tensor.inner_product")
}

fn arity(&self, _options: &Self::Options) -> Arity {
Expand Down
2 changes: 1 addition & 1 deletion vortex-tensor/src/scalar_fns/l2_norm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ impl ScalarFnVTable for L2Norm {
type Options = ApproxOptions;

fn id(&self) -> ScalarFnId {
ScalarFnId::new_ref("vortex.tensor.l2_norm")
ScalarFnId::from("vortex.tensor.l2_norm")
}

fn arity(&self, _options: &Self::Options) -> Arity {
Expand Down
Loading