Skip to content

TurboQuant cleanup part 2#7326

Merged
connortsui20 merged 4 commits intodevelopfrom
ct/tq-cleanup-2
Apr 7, 2026
Merged

TurboQuant cleanup part 2#7326
connortsui20 merged 4 commits intodevelopfrom
ct/tq-cleanup-2

Conversation

@connortsui20
Copy link
Copy Markdown
Contributor

Summary

Tracking issue: #7297

Adds named limit constants, removes the old double-quantized similarity path, and updates the docs to better match the current Stage 1 implementation.

It also replaces all remaining to_canonical usage in vortex-tensor with explicit execute(...) calls and tightens cast_possible_truncation handling by using targeted expect annotations or checked conversions instead of broad allows.

API Changes

Added 2 constants.

Testing

NA

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested a review from gatesn April 7, 2026 18:31
@connortsui20 connortsui20 added the changelog/chore A trivial change label Apr 7, 2026
@connortsui20 connortsui20 enabled auto-merge (squash) April 7, 2026 18:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will degrade performance by 17.72%

❌ 1 regressed benchmark
✅ 1121 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 50.1 µs 60.8 µs -17.72%

Comparing ct/tq-cleanup-2 (ce476ff) with develop (be65147)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit 8d55015 into develop Apr 7, 2026
63 of 65 checks passed
@connortsui20 connortsui20 deleted the ct/tq-cleanup-2 branch April 7, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants