Skip to content

Use an unsafe trait to reinterpret packed struct references as bytes#7336

Open
AdamGS wants to merge 1 commit intodevelopfrom
adamg/unsafe-packed-bytes-trait
Open

Use an unsafe trait to reinterpret packed struct references as bytes#7336
AdamGS wants to merge 1 commit intodevelopfrom
adamg/unsafe-packed-bytes-trait

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 8, 2026

Summary

This is a cosmetic change to make it clearer what is happening when re-interpreting references as raw bytes to serialize plans, making it harder to mis-use by making it a more specific trait.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from 0ax1 April 8, 2026 11:37
@AdamGS AdamGS added the changelog/chore A trivial change label Apr 8, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 8, 2026

Merging this PR will improve performance by 20.65%

⚡ 1 improved benchmark
✅ 1121 untouched benchmarks
⏩ 1530 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 60.2 µs 49.9 µs +20.65%

Comparing adamg/unsafe-packed-bytes-trait (178a612) with develop (95befa7)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant