Skip to content

better execute path#7341

Closed
joseph-isaacs wants to merge 11 commits into
developfrom
ji/better-execute
Closed

better execute path#7341
joseph-isaacs wants to merge 11 commits into
developfrom
ji/better-execute

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

No description provided.

joseph-isaacs and others added 5 commits March 11, 2026 18:57
RunsOn reads config from the default branch (develop) for public
repos. Add _extends to inherit runner config from .github-private
and pin arm64 AMI for prebuilt image testing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 8, 2026

Merging this PR will degrade performance by 48.75%

⚡ 7 improved benchmarks
❌ 25 regressed benchmarks
✅ 1066 untouched benchmarks
⏩ 1554 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 1000, 100)] 880.9 µs 1,323.7 µs -33.45%
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 10, 100)] 696.7 µs 1,334.7 µs -47.8%
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 100, 10)] 95.5 µs 152.2 µs -37.28%
Simulation chunked_dict_primitive_into_canonical[u64, (1000, 100, 100)] 988 µs 1,435.7 µs -31.18%
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 1000, 10)] 112 µs 159.1 µs -29.6%
Simulation chunked_dict_primitive_into_canonical[u64, (1000, 10, 10)] 120.4 µs 197.9 µs -39.16%
Simulation chunked_dict_primitive_into_canonical[u32, (1000, 100, 100)] 707.4 µs 1,347.3 µs -47.49%
Simulation chunked_dict_primitive_into_canonical[u32, (1000, 1000, 100)] 871.3 µs 1,321.2 µs -34.05%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 10, 10)] 120.7 µs 195.2 µs -38.14%
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 100, 100)] 712.7 µs 1,344.9 µs -47.01%
Simulation chunked_dict_primitive_into_canonical[f32, (1000, 10, 10)] 93.6 µs 150.5 µs -37.79%
Simulation chunked_dict_primitive_into_canonical[u64, (1000, 100, 10)] 123.9 µs 200.8 µs -38.27%
Simulation chunked_dict_primitive_into_canonical[u32, (1000, 1000, 10)] 111.6 µs 157.7 µs -29.2%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 100, 10)] 124.5 µs 199.1 µs -37.5%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 10, 100)] 955.1 µs 1,441.4 µs -33.74%
Simulation chunked_dict_primitive_into_canonical[u64, (1000, 10, 100)] 951.8 µs 1,443.5 µs -34.07%
Simulation chunked_dict_primitive_into_canonical[u64, (1000, 1000, 10)] 158.1 µs 209.6 µs -24.58%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 100, 100)] 989.3 µs 1,460.1 µs -32.25%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 1000, 10)] 157.6 µs 211.7 µs -25.59%
Simulation chunked_dict_primitive_into_canonical[u32, (1000, 10, 10)] 149.7 µs 175.3 µs -14.61%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/better-execute (f76dfec) with develop (cdebcdc)

Open in CodSpeed

Footnotes

  1. 1554 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

joseph-isaacs and others added 6 commits April 8, 2026 15:56
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Resolve conflict in .github/runs-on.yml by taking develop's ARM64 image config.

Signed-off-by: Joe Isaacs <joe@spiraldb.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/src/arrays/filter/vtable.rs
#	vortex-array/src/arrays/masked/vtable/mod.rs
#	vortex-array/src/arrays/slice/vtable.rs
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label May 18, 2026
@robert3005 robert3005 closed this May 22, 2026
@robert3005 robert3005 deleted the ji/better-execute branch May 22, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants