Skip to content

Fix semantic merge conflict between session serde and foreign encodings#7362

Merged
robert3005 merged 1 commit intodevelopfrom
rk/fmt
Apr 9, 2026
Merged

Fix semantic merge conflict between session serde and foreign encodings#7362
robert3005 merged 1 commit intodevelopfrom
rk/fmt

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

@robert3005 robert3005 commented Apr 9, 2026

Signed-off-by: Robert Kruszewski github@robertk.io

@robert3005
Fix semantic merge conflict between session serde and foreign encodings
e791202 
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) April 9, 2026 13:19
@robert3005 robert3005 added the changelog/skip Do not list PR in the changelog label Apr 9, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will degrade performance by 23.82%

❌ 24 regressed benchmarks
✅ 1098 untouched benchmarks
⏩ 1530 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation take_search[(0.005, 0.1)] 247.1 µs 320.2 µs -22.84%
❌ Simulation take_search[(0.005, 0.5)] 1.2 ms 1.5 ms -23.69%
❌ Simulation take_search[(0.005, 0.05)] 131.5 µs 168.3 µs -21.82%
❌ Simulation take_search[(0.1, 0.5)] 1.8 ms 2.2 ms -16.94%
❌ Simulation take_search[(0.01, 0.05)] 142.6 µs 179.3 µs -20.48%
❌ Simulation take_search[(0.005, 1.0)] 2.3 ms 3.1 ms -23.82%
❌ Simulation take_search[(0.01, 0.5)] 1.3 ms 1.6 ms -22.23%
❌ Simulation take_search_chunked[(0.005, 0.5)] 1.5 ms 1.8 ms -17.04%
❌ Simulation take_search_chunked[(0.005, 0.05)] 165.9 µs 197.1 µs -15.85%
❌ Simulation take_search_chunked[(0.01, 0.05)] 178.8 µs 210 µs -14.88%
❌ Simulation take_search[(0.1, 0.1)] 386.5 µs 459.6 µs -15.91%
❌ Simulation take_search_chunked[(0.005, 0.1)] 314.5 µs 376.7 µs -16.51%
❌ Simulation take_search[(0.01, 1.0)] 2.5 ms 3.3 ms -22.35%
❌ Simulation take_search_chunked[(0.005, 1.0)] 3 ms 3.6 ms -17.12%
❌ Simulation take_search[(0.1, 0.05)] 212.4 µs 249.2 µs -14.74%
❌ Simulation take_search_chunked[(0.01, 0.1)] 339 µs 401.2 µs -15.51%
❌ Simulation take_search_chunked[(0.01, 0.5)] 1.6 ms 1.9 ms -15.99%
❌ Simulation take_search[(0.01, 0.1)] 267.8 µs 341 µs -21.45%
❌ Simulation take_search[(0.1, 1.0)] 3.5 ms 4.3 ms -17.1%
❌ Simulation take_search_chunked[(0.01, 1.0)] 3.2 ms 3.9 ms -16.06%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Comparing rk/fmt (e791202) with develop (a30de02)2

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (84e4dc0) during the generation of this report, so a30de02 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@robert3005 robert3005 merged commit 957eb3a into develop Apr 9, 2026
63 of 65 checks passed
@robert3005 robert3005 deleted the rk/fmt branch April 9, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connortsui20 connortsui20 connortsui20 approved these changes

Assignees

No one assigned

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert3005 @connortsui20