Skip to content

duckdb: Reset validity instead of filling#7365

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-validity
Apr 10, 2026
Merged

duckdb: Reset validity instead of filling#7365
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-validity

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 9, 2026

  1. Reset validity if it's "all true" instead of filling manually.
  2. Set validity to true if parent array is constant (slicing won't affect that).
  3. Reset validity if buffer after copying is all ones or all zeroes.
  4. Copy validity mask and count ones in one pass

@myrrc myrrc requested a review from robert3005 April 9, 2026 15:29
@myrrc myrrc added the changelog/performance A performance improvement label Apr 9, 2026
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from 1d39f2d to e5db410 Compare April 9, 2026 15:30
@myrrc myrrc enabled auto-merge (squash) April 9, 2026 15:30
Comment thread vortex-duckdb/cpp/vector.cpp
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from e5db410 to 30483d5 Compare April 9, 2026 15:32
Comment thread vortex-duckdb/src/duckdb/vector.rs Outdated
Comment thread vortex-duckdb/src/exporter/mod.rs Outdated
Comment thread vortex-duckdb/src/exporter/vector.rs
Comment thread vortex-duckdb/src/exporter/vector.rs Outdated
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from 30483d5 to f7f88fe Compare April 9, 2026 17:31
@myrrc myrrc requested a review from joseph-isaacs April 9, 2026 17:33
Comment thread vortex-duckdb/src/exporter/vector.rs Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will not alter performance

✅ 1122 untouched benchmarks
⏩ 1455 skipped benchmarks1


Comparing myrrc/duckdb-validity (7658463) with develop (ac87fe0)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread vortex-buffer/src/bit/buf.rs Outdated
Comment thread vortex-buffer/src/bit/buf.rs
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from f7f88fe to 73ac072 Compare April 10, 2026 10:06
@myrrc myrrc requested a review from joseph-isaacs April 10, 2026 10:07
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from 73ac072 to fc276d9 Compare April 10, 2026 11:17
Comment thread vortex-duckdb/src/exporter/mod.rs Outdated
Comment thread vortex-duckdb/src/exporter/mod.rs Outdated
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/duckdb-validity branch from fc276d9 to 7658463 Compare April 10, 2026 12:50
@myrrc myrrc requested a review from joseph-isaacs April 10, 2026 12:50
Copy link
Copy Markdown
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEE

@myrrc myrrc merged commit a78897f into develop Apr 10, 2026
63 of 64 checks passed
@myrrc myrrc deleted the myrrc/duckdb-validity branch April 10, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants