Skip to content

fix: maturin never logs#7367

Merged
connortsui20 merged 1 commit intodevelopfrom
dk/fix-ci
Apr 9, 2026
Merged

fix: maturin never logs#7367
connortsui20 merged 1 commit intodevelopfrom
dk/fix-ci

Conversation

@danking
Copy link
Copy Markdown
Contributor

@danking danking commented Apr 9, 2026

Maturin logs on stdout non-deterministically race with maturin printing the wheel path (which also goes to stdout). If the wheel path is not last, the Pytest - Vortex step fails.

Maturin logs on stdout non-deterministically race with maturin printing the wheel path (which also
goes to stdout). If the wheel path is not last, the `Pytest - Vortex` step fails.

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking added the changelog/fix A bug fix label Apr 9, 2026
@danking danking marked this pull request as ready for review April 9, 2026 15:55
@connortsui20 connortsui20 enabled auto-merge (squash) April 9, 2026 15:55
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will improve performance by 29.94%

⚡ 2 improved benchmarks
✅ 1120 untouched benchmarks
⏩ 1530 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_10k_random 251.2 µs 193.3 µs +29.94%
Simulation take_10k_contiguous 314.9 µs 257 µs +22.52%

Comparing dk/fix-ci (9239456) with develop (8974afe)

Open in CodSpeed

Footnotes

  1. 1530 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 merged commit ccc6590 into develop Apr 9, 2026
64 of 65 checks passed
@connortsui20 connortsui20 deleted the dk/fix-ci branch April 9, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants