Skip to content

Remove MaskMut and unused functions from BitBufferMut#7379

Merged
robert3005 merged 2 commits intodevelopfrom
rk/nomaskmut
Apr 10, 2026
Merged

Remove MaskMut and unused functions from BitBufferMut#7379
robert3005 merged 2 commits intodevelopfrom
rk/nomaskmut

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

A lot of this logic dates back to earlier expriments. We don't need this logic
and in some cases it's duplicate with a logic we have optimised elsewhere

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 enabled auto-merge (squash) April 9, 2026 23:37
@robert3005 robert3005 added the changelog/break A breaking API change label Apr 9, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026

Merging this PR will degrade performance by 11.03%

❌ 3 regressed benchmarks
✅ 1119 untouched benchmarks
⏩ 1455 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation true_count_arrow_buffer[128] 726.4 ns 813.9 ns -10.75%
Simulation true_count_arrow_buffer[1024] 940.8 ns 1,057.5 ns -11.03%
Simulation true_count_arrow_buffer[2048] 1 µs 1.1 µs -10.34%

Comparing rk/nomaskmut (b56c88e) with develop (7618c23)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 merged commit d296528 into develop Apr 10, 2026
59 of 60 checks passed
@robert3005 robert3005 deleted the rk/nomaskmut branch April 10, 2026 09:34
joseph-isaacs added a commit to joseph-isaacs/vortex that referenced this pull request Apr 10, 2026
The function used MaskMut which was removed in develop (vortex-data#7379).
The merge conflict resolution incorrectly kept this dead function.

Signed-off-by: Joe Isaacs <joe@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants