Ignore dead_code warnings on scalar bit transpose code#7408
Merged
robert3005 merged 1 commit intodevelopfrom Apr 13, 2026
Merged
Ignore dead_code warnings on scalar bit transpose code#7408robert3005 merged 1 commit intodevelopfrom
robert3005 merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
0ax1
reviewed
Apr 13, 2026
| /// This version uses 64-bit gather + parallel bit operations instead of | ||
| /// extracting bits one by one. Typically 5-10x faster than the basic scalar version. | ||
| #[inline(never)] | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
In practice looks like a if x86
0ax1
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely we shouldn't use expect here but we also don't test on architectures
where this wouldn't be dead code
Signed-off-by: Robert Kruszewski github@robertk.io