Skip to content

duckdb: Exit earlier on Validity::AllFalse#7411

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-validity-exit
Apr 13, 2026
Merged

duckdb: Exit earlier on Validity::AllFalse#7411
myrrc merged 1 commit intodevelopfrom
myrrc/duckdb-validity-exit

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Apr 13, 2026

  1. Make duckdb all-invalid exporter a unit type:
    If we set underlying vector's validity to "all false",
    duckdb won't read underlying values so you don't need to
    fill them
  2. Exit early on exporter branches if validity is all false.
    Saves a ConstantArray creation + execute

@myrrc myrrc force-pushed the myrrc/duckdb-validity-exit branch from f1f161f to ba9b906 Compare April 13, 2026 14:37
@myrrc myrrc requested a review from 0ax1 April 13, 2026 14:37
@myrrc myrrc added the changelog/chore A trivial change label Apr 13, 2026
@myrrc myrrc force-pushed the myrrc/duckdb-validity-exit branch from ba9b906 to c080212 Compare April 13, 2026 14:41
@myrrc myrrc enabled auto-merge (squash) April 13, 2026 14:43
@myrrc myrrc force-pushed the myrrc/duckdb-validity-exit branch from c080212 to be1c355 Compare April 13, 2026 14:47
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/duckdb-validity-exit branch from be1c355 to 0136db1 Compare April 13, 2026 14:52
@myrrc myrrc merged commit 44c511d into develop Apr 13, 2026
60 checks passed
@myrrc myrrc deleted the myrrc/duckdb-validity-exit branch April 13, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants