Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions encodings/alp/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pub fn vortex_alp::ALP::validate(&self, data: &vortex_alp::ALPData, dtype: &vort

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_alp::ALP> for vortex_alp::ALP

pub fn vortex_alp::ALP::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_alp::ALP>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_alp::ALP::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_alp::ALP>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityChild<vortex_alp::ALP> for vortex_alp::ALP

Expand Down Expand Up @@ -194,7 +194,7 @@ pub fn vortex_alp::ALPRD::validate(&self, data: &vortex_alp::ALPRDData, dtype: &

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_alp::ALPRD> for vortex_alp::ALPRD

pub fn vortex_alp::ALPRD::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_alp::ALPRD>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_alp::ALPRD::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_alp::ALPRD>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityChild<vortex_alp::ALPRD> for vortex_alp::ALPRD

Expand Down
7 changes: 1 addition & 6 deletions encodings/alp/src/alp/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexExpect;
Expand All @@ -15,11 +14,7 @@ use crate::ALPFloat;
use crate::match_each_alp_float_ptype;

impl OperationsVTable<ALP> for ALP {
fn scalar_at(
array: ArrayView<'_, ALP>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, ALP>, index: usize) -> VortexResult<Scalar> {
if let Some(patches) = array.patches()
&& let Some(patch) = patches.get_patched(index)?
{
Expand Down
7 changes: 1 addition & 6 deletions encodings/alp/src/alp_rd/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::dtype::PType;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -13,11 +12,7 @@ use crate::ALPRD;
use crate::ALPRDArrayExt;

impl OperationsVTable<ALPRD> for ALPRD {
fn scalar_at(
array: ArrayView<'_, ALPRD>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, ALPRD>, index: usize) -> VortexResult<Scalar> {
// The left value can either be a direct value, or an exception.
// The exceptions array represents exception positions with non-null values.
let maybe_patched_value = match array.left_parts_patches() {
Expand Down
2 changes: 1 addition & 1 deletion encodings/bytebool/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub fn vortex_bytebool::ByteBool::validate(&self, data: &Self::ArrayData, dtype:

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_bytebool::ByteBool> for vortex_bytebool::ByteBool

pub fn vortex_bytebool::ByteBool::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_bytebool::ByteBool>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_bytebool::ByteBool::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_bytebool::ByteBool>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_bytebool::ByteBool> for vortex_bytebool::ByteBool

Expand Down
6 changes: 1 addition & 5 deletions encodings/bytebool/src/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,7 @@ impl ValidityVTable<ByteBool> for ByteBool {
}

impl OperationsVTable<ByteBool> for ByteBool {
fn scalar_at(
array: ArrayView<'_, ByteBool>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, ByteBool>, index: usize) -> VortexResult<Scalar> {
Ok(Scalar::bool(
array.buffer.as_host()[index] == 1,
array.dtype().nullability(),
Expand Down
2 changes: 1 addition & 1 deletion encodings/datetime-parts/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub fn vortex_datetime_parts::DateTimeParts::validate(&self, _data: &Self::Array

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_datetime_parts::DateTimeParts> for vortex_datetime_parts::DateTimeParts

pub fn vortex_datetime_parts::DateTimeParts::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_datetime_parts::DateTimeParts>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_datetime_parts::DateTimeParts::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_datetime_parts::DateTimeParts>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityChild<vortex_datetime_parts::DateTimeParts> for vortex_datetime_parts::DateTimeParts

Expand Down
7 changes: 1 addition & 6 deletions encodings/datetime-parts/src/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::dtype::DType;
use vortex_array::extension::datetime::Timestamp;
use vortex_array::scalar::Scalar;
Expand All @@ -17,11 +16,7 @@ use crate::timestamp;
use crate::timestamp::TimestampParts;

impl OperationsVTable<DateTimeParts> for DateTimeParts {
fn scalar_at(
array: ArrayView<'_, DateTimeParts>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, DateTimeParts>, index: usize) -> VortexResult<Scalar> {
let DType::Extension(ext) = array.dtype().clone() else {
vortex_panic!(
"DateTimePartsArray must have extension dtype, found {}",
Expand Down
2 changes: 1 addition & 1 deletion encodings/decimal-byte-parts/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub fn vortex_decimal_byte_parts::DecimalByteParts::validate(&self, _data: &Self

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_decimal_byte_parts::DecimalByteParts> for vortex_decimal_byte_parts::DecimalByteParts

pub fn vortex_decimal_byte_parts::DecimalByteParts::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_decimal_byte_parts::DecimalByteParts>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_decimal_byte_parts::DecimalByteParts::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_decimal_byte_parts::DecimalByteParts>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityChild<vortex_decimal_byte_parts::DecimalByteParts> for vortex_decimal_byte_parts::DecimalByteParts

Expand Down
6 changes: 1 addition & 5 deletions encodings/decimal-byte-parts/src/decimal_byte_parts/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,7 @@ fn to_canonical_decimal(
}

impl OperationsVTable<DecimalByteParts> for DecimalByteParts {
fn scalar_at(
array: ArrayView<'_, DecimalByteParts>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, DecimalByteParts>, index: usize) -> VortexResult<Scalar> {
// TODO(joe): support parts len != 1
let scalar = array.msp().scalar_at(index)?;

Expand Down
8 changes: 4 additions & 4 deletions encodings/fastlanes/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ pub fn vortex_fastlanes::BitPacked::validate(&self, data: &Self::ArrayData, dtyp

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_fastlanes::BitPacked> for vortex_fastlanes::BitPacked

pub fn vortex_fastlanes::BitPacked::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::BitPacked::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::BitPacked>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_fastlanes::BitPacked> for vortex_fastlanes::BitPacked

Expand Down Expand Up @@ -324,7 +324,7 @@ pub fn vortex_fastlanes::Delta::validate(&self, data: &Self::ArrayData, dtype: &

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_fastlanes::Delta> for vortex_fastlanes::Delta

pub fn vortex_fastlanes::Delta::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::Delta>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::Delta::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::Delta>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_fastlanes::Delta> for vortex_fastlanes::Delta

Expand Down Expand Up @@ -414,7 +414,7 @@ pub fn vortex_fastlanes::FoR::validate(&self, data: &Self::ArrayData, dtype: &vo

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_fastlanes::FoR> for vortex_fastlanes::FoR

pub fn vortex_fastlanes::FoR::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::FoR>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::FoR::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::FoR>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityChild<vortex_fastlanes::FoR> for vortex_fastlanes::FoR

Expand Down Expand Up @@ -522,7 +522,7 @@ pub fn vortex_fastlanes::RLE::validate(&self, data: &Self::ArrayData, dtype: &vo

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_fastlanes::RLE> for vortex_fastlanes::RLE

pub fn vortex_fastlanes::RLE::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::RLE>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fastlanes::RLE::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fastlanes::RLE>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_fastlanes::RLE> for vortex_fastlanes::RLE

Expand Down
7 changes: 1 addition & 6 deletions encodings/fastlanes/src/bitpacking/vtable/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexResult;
Expand All @@ -11,11 +10,7 @@ use crate::BitPacked;
use crate::bitpack_decompress;
use crate::bitpacking::array::BitPackedArrayExt;
impl OperationsVTable<BitPacked> for BitPacked {
fn scalar_at(
array: ArrayView<'_, BitPacked>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, BitPacked>, index: usize) -> VortexResult<Scalar> {
Ok(
if let Some(patches) = array.patches()
&& let Some(patch) = patches.get_patched(index)?
Expand Down
7 changes: 1 addition & 6 deletions encodings/fastlanes/src/delta/vtable/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::IntoArray;
use vortex_array::ToCanonical;
use vortex_array::scalar::Scalar;
Expand All @@ -11,11 +10,7 @@ use vortex_error::VortexResult;

use super::Delta;
impl OperationsVTable<Delta> for Delta {
fn scalar_at(
array: ArrayView<'_, Delta>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, Delta>, index: usize) -> VortexResult<Scalar> {
let decompressed = array.array().slice(index..index + 1)?.to_primitive();
decompressed.into_array().scalar_at(0)
}
Expand Down
7 changes: 1 addition & 6 deletions encodings/fastlanes/src/for/vtable/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::match_each_integer_ptype;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -12,11 +11,7 @@ use vortex_error::VortexResult;
use super::FoR;
use crate::r#for::array::FoRArrayExt;
impl OperationsVTable<FoR> for FoR {
fn scalar_at(
array: ArrayView<'_, FoR>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, FoR>, index: usize) -> VortexResult<Scalar> {
let encoded_pvalue = array.encoded().scalar_at(index)?;
let encoded_pvalue = encoded_pvalue.as_primitive();
let reference = array.reference_scalar();
Expand Down
7 changes: 1 addition & 6 deletions encodings/fastlanes/src/rle/vtable/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
use vortex_error::VortexExpect;
Expand All @@ -13,11 +12,7 @@ use crate::FL_CHUNK_SIZE;
use crate::rle::RLEArrayExt;

impl OperationsVTable<RLE> for RLE {
fn scalar_at(
array: ArrayView<'_, RLE>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, RLE>, index: usize) -> VortexResult<Scalar> {
let offset_in_chunk = array.offset();
let chunk_relative_idx = array.indices().scalar_at(offset_in_chunk + index)?;

Expand Down
2 changes: 1 addition & 1 deletion encodings/fsst/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub fn vortex_fsst::FSST::validate(&self, data: &Self::ArrayData, dtype: &vortex

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_fsst::FSST> for vortex_fsst::FSST

pub fn vortex_fsst::FSST::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fsst::FSST>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_fsst::FSST::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_fsst::FSST>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_fsst::FSST> for vortex_fsst::FSST

Expand Down
7 changes: 1 addition & 6 deletions encodings/fsst/src/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::arrays::varbin::varbin_scalar;
use vortex_array::scalar::Scalar;
use vortex_array::vtable::OperationsVTable;
Expand All @@ -14,11 +13,7 @@ use crate::FSST;
use crate::FSSTArrayExt;

impl OperationsVTable<FSST> for FSST {
fn scalar_at(
array: ArrayView<'_, FSST>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, FSST>, index: usize) -> VortexResult<Scalar> {
let compressed = array.codes().scalar_at(index)?;
let binary_datum = compressed.as_binary().value().vortex_expect("non-null");

Expand Down
7 changes: 1 addition & 6 deletions encodings/parquet-variant/src/operations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use chrono::Timelike;
use parquet_variant::Variant as PqVariant;
use vortex_array::ArrayRef;
use vortex_array::ArrayView;
use vortex_array::ExecutionCtx;
use vortex_array::dtype::DType;
use vortex_array::dtype::DecimalDType;
use vortex_array::dtype::FieldName;
Expand Down Expand Up @@ -38,11 +37,7 @@ impl OperationsVTable<ParquetVariant> for ParquetVariant {
/// | non-NULL | NULL | Un-shredded: decode from metadata + value bytes |
/// | NULL | non-NULL | Perfectly shredded: use typed_value directly |
/// | non-NULL | non-NULL | Partially shredded object (typed_value takes priority) |
fn scalar_at(
array: ArrayView<'_, ParquetVariant>,
index: usize,
_ctx: &mut ExecutionCtx,
) -> VortexResult<Scalar> {
fn scalar_at(array: ArrayView<'_, ParquetVariant>, index: usize) -> VortexResult<Scalar> {
if array.validity()?.is_null(index)? {
return Ok(Scalar::null(DType::Variant(Nullability::Nullable)));
}
Expand Down
4 changes: 2 additions & 2 deletions encodings/pco/public-api.lock
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ pub fn vortex_pco::Pco::validate(&self, data: &vortex_pco::PcoData, dtype: &vort

impl vortex_array::array::vtable::operations::OperationsVTable<vortex_pco::Pco> for vortex_pco::Pco

pub fn vortex_pco::Pco::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_pco::Pco>, index: usize, _ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>
pub fn vortex_pco::Pco::scalar_at(array: vortex_array::array::view::ArrayView<'_, vortex_pco::Pco>, index: usize) -> vortex_error::VortexResult<vortex_array::scalar::Scalar>

impl vortex_array::array::vtable::validity::ValidityVTable<vortex_pco::Pco> for vortex_pco::Pco

Expand Down Expand Up @@ -86,7 +86,7 @@ pub struct vortex_pco::PcoData

impl vortex_pco::PcoData

pub fn vortex_pco::PcoData::decompress(&self, unsliced_validity: &vortex_array::validity::Validity, ctx: &mut vortex_array::executor::ExecutionCtx) -> vortex_error::VortexResult<vortex_array::arrays::primitive::vtable::PrimitiveArray>
pub fn vortex_pco::PcoData::decompress(&self, unsliced_validity: &vortex_array::validity::Validity, unsliced_mask: &vortex_mask::Mask) -> vortex_error::VortexResult<vortex_array::arrays::primitive::vtable::PrimitiveArray>

pub fn vortex_pco::PcoData::from_array(array: vortex_array::array::erased::ArrayRef, level: usize, nums_per_page: usize) -> vortex_error::VortexResult<Self>

Expand Down
Loading
Loading