Skip to content

chore: dedup formats in sql engine runner #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ax1 merged 1 commit into from
Apr 15, 2026
+5 −1
Merged

chore: dedup formats in sql engine runner #7459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vortex-bench/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use std::time::Instant;

use indicatif::ProgressBar;
use vortex::error::vortex_panic;
use vortex::utils::aliases::hash_set::HashSet;

use crate::Benchmark;
use crate::BenchmarkDataset;
Expand Down Expand Up @@ -67,6 +68,7 @@ pub struct SqlBenchmarkRunner {
benchmark_dataset: BenchmarkDataset,
storage: String,
expected_row_counts: Option<Vec<usize>>,
/// Deduplicated, preserving insertion order.
formats: Vec<Format>,
memory_tracker: Option<BenchmarkMemoryTracker>,
hide_progress_bar: bool,
Expand All @@ -79,10 +81,12 @@ impl SqlBenchmarkRunner {
pub fn new<B: Benchmark + ?Sized>(
benchmark: &B,
engine: Engine,
formats: Vec<Format>,
formats: impl IntoIterator<Item = Format>,
track_memory: bool,
hide_progress_bar: bool,
) -> anyhow::Result<Self> {
let mut seen = HashSet::new();
let formats: Vec<Format> = formats.into_iter().filter(|f| seen.insert(*f)).collect();
let storage = url_scheme_to_storage(benchmark.data_url())?;

let memory_tracker = track_memory.then(BenchmarkMemoryTracker::new);
Expand Down
Loading