Skip to content

fix: add validity no_nulls and fix usage #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-isaacs merged 3 commits into from
Apr 16, 2026
+10 −2
Merged

fix: add validity no_nulls and fix usage #7487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ab2ff2
fix
joseph-isaacs Apr 16, 2026
b96c6bf
fix
joseph-isaacs Apr 16, 2026
9edc0e6
fix
joseph-isaacs Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vortex-array/src/arrow/record_batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ impl TryFrom<&ArrayRef> for RecordBatch {
};

vortex_ensure!(
matches!(struct_array.validity()?, Validity::AllValid),
struct_array.validity()?.no_nulls(),
"RecordBatch can only be constructed from StructArray with no nulls"
);

Expand Down
7 changes: 7 additions & 0 deletions vortex-array/src/validity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ impl Validity {
}
}

/// Returns `true` if this validity guarantees no null values, i.e. it is either
/// [`Validity::NonNullable`] or [`Validity::AllValid`].
#[inline]
pub fn no_nulls(&self) -> bool {
matches!(self, Self::NonNullable | Self::AllValid)
}

/// The union nullability and validity.
#[inline]
pub fn union_nullability(self, nullability: Nullability) -> Self {
Expand Down
Loading